Review dropdown filter behavior for Ticket owner dropdown

[stefanhaerter]

In unit tests scripts/test/Selenium/Agent/AgentTicketActionCommon/AgentTicketOwner.t and scripts/test/Selenium/Agent/AgentTicketZoom.t, a failure can be observed when a new ticket owner is to be set. Assumption is that both failures are related to the same issue.

Additional observation: When using the dropdown filter manually via GUI, it works, but it does not when triggering a click event via Selenium test.

[stefanhaerter]

See #3100 for more context

[stefanhaerter]

So far, the investigation showed: The click via GUI is indeed treated differently than triggering the click event via javascript. This can be observed via console.trace() at a fitting location in var/httpd/htdocs/js/Core.UI.InputFields.js. The mechanism in the GUI involves focus on the search field, as far as I could manage to find out.

[MichaelThumes]

Re: AgentTicketOwner.t

this looks promising:

diff --git a/scripts/test/Selenium/Agent/AgentTicketActionCommon/AgentTicketOwner.t b/scripts/test/Selenium/Agent/AgentTicketActionCommon/AgentTicketOwner.t
index 1a3419452..5b03d7e71 100644
--- a/scripts/test/Selenium/Agent/AgentTicketActionCommon/AgentTicketOwner.t
+++ b/scripts/test/Selenium/Agent/AgentTicketActionCommon/AgentTicketOwner.t
@@ -206,9 +206,11 @@ $Selenium->RunTest(
             "Out of office message is found for the user $TestUser[1]"
         );
 
-        # Change ticket owner by clicking.
-        # TODO: this does not actually select the user 1 and the test script fails
-        $UserSelectionElement->execute_script(q{ $(arguments[0]).click() });
+        # Change ticket owner by fakeing a click.
+        # simple click does not work due to lazy loading
+
+        my $UserSelectionElementForValueSet =  $Selenium->find_element( qq{#NewOwnerID}, 'css' );
+        $UserSelectionElementForValueSet->execute_script(qq{ arguments[0].value="$UserID[1]"; });
 
         $Selenium->find_element( "#Subject",        'css' )->send_keys('Test');
         $Selenium->find_element( "#RichText",       'css' )->send_keys('Test');

Not super-happy but it makes the test green, and as all my attempts to somehow trigger the lazy load from Selenium failed...

Didn't find time to look into AgentTicketZoom.t yet, looking forward to do so.

[stefanhaerter]

Looks great, thank you for taking the time!

[bschmalhofer]

I think that the better solution is to use the click() method on the filter checkbox. I try to prepare a patch,

[stefanhaerter]

I remember trying out a few things around the click() method, but not exactly which - only that none of my tests worked, so I discarded them.

[bschmalhofer]

Yes, using the click() method made the browser output more like the expected output. But actually selecting the owner did still not work. So I propose to use @MichaelThumes 's solution.

Are there objections to applying #3990 ?

[MichaelThumes]

The following would also work on my machine (in the sense of making the test green):

#        my $UserSelectionElementForValueSet =  $Selenium->find_element( qq{#NewOwnerID}, 'css' );
#        $UserSelectionElementForValueSet->execute_script(qq{ arguments[0].value="$UserID[1]"; });

        $UserSelectionElement->execute_script( q{document.querySelector('label[for="NewOwnerID"]').click();} );
        sleep(5);
        $UserSelectionElement->execute_script( q{document.querySelectorAll('#NewOwnerID_Select ul li a')[0].click(); } );
        sleep(5);
        $UserSelectionElement->execute_script( q{document.querySelectorAll('#NewOwnerID_Select ul li a')[0].click(); } );

Not that it makes me any happier - whilst closer to actually testing the UI, it now relies on 'benefits of sleep'. Plus I would have a hard time to explain why this - unlike the 20 or so much more straightforward solutions I tried first - actually works .-(

[bschmalhofer]

@MichaelThumes , yes, I would prefer your latest solution with the three clicks as it is closer to what is happening in the GUI.

[MichaelThumes]

had a look at AgentTicketZoom.t as well

does not look related to me - rather simply html/css changes?. Anyway here comes another candidate:

diff --git a/scripts/test/Selenium/Agent/AgentTicketZoom.t b/scripts/test/Selenium/Agent/AgentTicketZoom.t
index b5f7d2cb0..10f9d0b3c 100644
--- a/scripts/test/Selenium/Agent/AgentTicketZoom.t
+++ b/scripts/test/Selenium/Agent/AgentTicketZoom.t
@@ -312,7 +312,7 @@ $Selenium->RunTest(
         );
 
         # click to sort by article number
-        $Selenium->find_element("//th[\@class='No Sortable tablesorter-header tablesorter-headerUnSorted']")->click();
+        $Selenium->find_element("//div[\@class='tablesorter-header-inner']/a")->click();
 
         # verify change in article order on column header click, test Core.UI.Table.Sort.js
         $Self->Is(