Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeleniumTesting: fix TODO tests for setting Owner, Responsible, State #748

Closed
bschmalhofer opened this issue Jan 21, 2021 · 5 comments
Closed
Labels
selenium Related to fixing or improving testing with Selenium unittests Requests wrt unittests
Milestone

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jan 21, 2021

In scripts/test/Selenium/Agent/AgentTicketActionCommon/AgentTicketFreeText.t some tests are commented out because Selenium could not perform the action. This manifested itself in a time out. The relevant lines start on line 395.

My impression is that for these fields there are extra JS callbacks that prevent setting the fields Owner, Responsible, and State to an empty value. I suppose that this functionality is as intended and that only the test scripts should be enhanced to handle that case.

@bschmalhofer bschmalhofer added the selenium Related to fixing or improving testing with Selenium label Jan 21, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jan 21, 2021
bschmalhofer added a commit that referenced this issue Jan 21, 2021
@bschmalhofer bschmalhofer changed the title SeleniumTesting: reactivate skipped tests for setting Owner, Responsible, State SeleniumTesting: fix TODO tests for setting Owner, Responsible, State May 8, 2021
bschmalhofer added a commit that referenced this issue May 8, 2021
instead of commenting them out
bschmalhofer added a commit that referenced this issue May 8, 2021
@bschmalhofer
Copy link
Contributor Author

The timeouts still occur, but not consistently at the same changes. The cause is not clear. Probably not related to problems with changing the config settings.

@bschmalhofer
Copy link
Contributor Author

Still some TODO tests in scripts/test/Selenium/Agent/AgentTicketActionCommon/AgentTicketFreeText.t

@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Sep 11, 2021

I still don't understand what is going on. Still looks like the selection list .InputField_ListContainer is not removed when an input field is set.
Refactored the test script a little but, such that tests are reorganized in subtests.

@reneeb reneeb added the unittests Requests wrt unittests label Jan 28, 2022
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 11.0 Feb 23, 2023
@stefanhaerter
Copy link
Contributor

Done with commit e6abd29 for issue #3100.

Closing the issue.

@bschmalhofer
Copy link
Contributor Author

Set the milestone to OTOBO 11.0.3, the first patch level release that contained the patch,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
selenium Related to fixing or improving testing with Selenium unittests Requests wrt unittests
Projects
None yet
Development

No branches or pull requests

3 participants