fix(Stack): swap image row and column pixel spacing + relaxing isequa…

…l compar… (cornerstonejs#566)

Co-authored-by: Rodolfo <[email protected]>

packages/core/src/RenderingEngine/StackViewport.ts

@@ -1315,9 +1315,9 @@ class StackViewport extends Viewport implements IStackViewport {
     // using spacing, size, and direction only for now
     return (
       (isSameXSpacing ||
-        (image.rowPixelSpacing === null && xSpacing === 1.0)) &&
+        (image.columnPixelSpacing === null && xSpacing === 1.0)) &&
       (isSameYSpacing ||
-        (image.columnPixelSpacing === null && ySpacing === 1.0)) &&
+        (image.rowPixelSpacing === null && ySpacing === 1.0)) &&
       xVoxels === image.columns &&
       yVoxels === image.rows &&
       isEqual(imagePlaneModule.rowCosines, <Point3>rowCosines) &&

packages/core/src/utilities/isEqual.ts

@@ -53,15 +53,6 @@ export default function isEqual<ValueType>(
     return false;
   }
 
-  // typeof object must have same constructor
-  if (
-    typeof v1 === 'object' &&
-    typeof v2 === 'object' &&
-    v1.constructor !== v2.constructor
-  ) {
-    return false;
-  }
-
   if (isNumberType(v1) && isNumberType(v2)) {
     return areNumbersEqualWithTolerance(v1, v2, tolerance);
   }

packages/core/test/utils_test.js

@@ -19,17 +19,36 @@ describe('Cornerstone-render Utilities:', function () {
     expect(isEqual(Infinity, Infinity, 0.0001)).toBe(false);
     expect(isEqual(NaN, NaN, 0.0001)).toBe(false);
 
+    const typedArray0 = new Float32Array([1.0, 2.1]);
     const typedArray1 = new Float32Array([1.0, 1.2]);
     const typedArray2 = new Float32Array([1.0, 1.2]);
     const typedArray3 = new Float64Array([1.0, 1.2]);
     const typedArray4 = new Float64Array([1.01, 1.202]);
     const typedArray5 = new Int16Array([1, 2]);
     const typedArray6 = new Int16Array([1, 2]);
+    const typedArray7 = new Int16Array([1, 3]);
 
     expect(isEqual(typedArray1, typedArray2, 0.0001)).toBe(true);
     expect(isEqual(typedArray3, typedArray4, 0.1)).toBe(true);
-    expect(isEqual(typedArray5, typedArray6, 0.0001)).toBe(true);
-    expect(isEqual(typedArray1, typedArray3, 0.1)).toBe(false);
+    expect(isEqual(typedArray3, typedArray4, 0.0001)).toBe(false);
+    expect(isEqual(typedArray3, typedArray4, 0.0001)).toEqual(
+      isEqual(typedArray4, typedArray3, 0.0001)
+    );
+    expect(isEqual(typedArray5, typedArray6, 0.1)).toBe(true);
+    expect(isEqual(typedArray5, typedArray6, 0.001)).toBe(true);
+    expect(isEqual(typedArray5, typedArray7, 0.1)).toBe(false);
+    expect(isEqual(typedArray1, typedArray3, 0.1)).toBe(true);
+    expect(isEqual(typedArray1, typedArray3, 0.0001)).toBe(true);
+    expect(isEqual(typedArray1, typedArray5, 0.0001)).toBe(false);
+    expect(isEqual(typedArray1, typedArray5, 0.01)).toBe(false);
+    expect(isEqual(typedArray0, typedArray5, 0.01)).toBe(false);
+    expect(isEqual(typedArray0, typedArray5, 0.1)).toBe(true);
+    expect(isEqual(typedArray0, typedArray5, 0.1)).toEqual(
+      isEqual(typedArray5, typedArray0, 0.1)
+    );
+    expect(isEqual(typedArray0, typedArray5, 0.1)).toEqual(
+      isEqual(typedArray5, typedArray5, 0.1)
+    );
   });
 
   it('Should correctly calculate line and plane intersection', () => {