Support for Heroku #186
Merged
Support for Heroku #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine to me, and will probably help in other cases with ABI-versioned libsodium releases besides just Heroku |
|
This also helped on Travis CI. Users can now use the Xenial build environment and do: dist: xenial
addons:
apt:
packages:
- libsodium18May be worth adding this |
|
@tarcieri Would it be possible to cut a new gem version with this fix? It also fixes installation for Docker with the libsodium package. The rbnacl gem fails to load without this change. Thanks! |
|
I was hoping to get #189 addressed first before cutting another release |
Merged
adamruzicka
added a commit
to adamruzicka/foreman-packaging
that referenced
this pull request
Jul 27, 2021
The patch is taken from this PR RubyCrypto/rbnacl#186.
1 task
adamruzicka
added a commit
to adamruzicka/foreman-packaging
that referenced
this pull request
Jul 27, 2021
The patch is taken from this PR RubyCrypto/rbnacl#186.
adamruzicka
added a commit
to adamruzicka/foreman-packaging
that referenced
this pull request
Jul 27, 2021
The patch is taken from this PR RubyCrypto/rbnacl#186.
adamruzicka
added a commit
to adamruzicka/foreman-packaging
that referenced
this pull request
Jul 27, 2021
The patch is taken from this PR RubyCrypto/rbnacl#186.
adamruzicka
added a commit
to adamruzicka/foreman-packaging
that referenced
this pull request
Jul 27, 2021
The patch is taken from this PR RubyCrypto/rbnacl#186.
adamruzicka
added a commit
to adamruzicka/foreman-packaging
that referenced
this pull request
Jul 27, 2021
The patch is taken from this PR RubyCrypto/rbnacl#186.
pcreech
pushed a commit
to theforeman/foreman-packaging
that referenced
this pull request
Aug 4, 2021
The patch is taken from this PR RubyCrypto/rbnacl#186.
adamruzicka
added a commit
to adamruzicka/foreman-packaging
that referenced
this pull request
Aug 5, 2021
The patch is taken from this PR RubyCrypto/rbnacl#186. (cherry picked from commit 8a6df84)
zjhuntin
pushed a commit
to theforeman/foreman-packaging
that referenced
this pull request
Aug 10, 2021
The patch is taken from this PR RubyCrypto/rbnacl#186. (cherry picked from commit 8a6df84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR allows rbnacl to work with Heroku out-of-the-box (since Heroku is a pretty popular platform for Ruby developers). FFI allows you to specify alternate file names, so it shouldn't cause any issues for other platforms.
Tested on Mac, the heroku-16 stack, and the heroku-18 stack.