-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panda, tiger, eagle #7
Open
noahpatterson
wants to merge
1
commit into
RubyoffRails:master
Choose a base branch
from
noahpatterson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
require './spec_helper' | ||
require "./terminator" | ||
|
||
describe BadTerminator do | ||
it "should destroy_john_connor" do | ||
subject.destroy_john_connor! | ||
subject.current_mission.should eq("destroy: john_connor") | ||
end | ||
|
||
it "should destroy_sarah_connor" do | ||
subject.destroy_sarah_connor! | ||
subject.current_mission.should eq("destroy: sarah_connor") | ||
end | ||
|
||
it 'should not protect john' do | ||
expect(subject.protects?('John Connor')).to be_false | ||
end | ||
|
||
it 'should not protect Sarah' do | ||
expect(subject.protects?('Sarah Connor')).to be_false | ||
end | ||
|
||
it 'should not protect Bob' do | ||
expect(subject.protects?('Bob')).to be_false | ||
puts 'poor bob' | ||
end | ||
|
||
it 'should not be good if it is trying to destory someone' do | ||
subject.destroy_sarah_connor! | ||
expect(subject.good?).to be_false | ||
end | ||
|
||
end | ||
|
||
describe GoodTerminator do | ||
it "should protect_john_connor" do | ||
subject.protect_john_connor! | ||
subject.current_mission.should eq("protect: john_connor") | ||
end | ||
|
||
|
||
it "should protect_sarah_connor" do | ||
subject.protect_sarah_connor! | ||
subject.current_mission.should eq("protect: sarah_connor") | ||
end | ||
|
||
it 'should protect john' do | ||
expect(subject.protects?('John Connor')).to be_true | ||
end | ||
|
||
it 'should protect Sarah' do | ||
expect(subject.protects?('Sarah Connor')).to be_true | ||
end | ||
|
||
it 'should not protect Bob' do | ||
expect(subject.protects?('Bob')).to be_false | ||
puts 'poor bob' | ||
end | ||
|
||
it 'should be good if it is not trying to destory someone' do | ||
subject.protect_sarah_connor! | ||
expect(subject.good?).to be_true | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
require 'rspec' | ||
|
||
|
||
|
||
|
||
RSpec.configure do |config| | ||
# Use color in STDOUT | ||
config.color_enabled = true | ||
|
||
# Use color not only in STDOUT but also in pagers and files | ||
config.tty = true | ||
|
||
# Use the specified formatter | ||
config.formatter = :documentation # :progress, :html, :textmate | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,38 @@ | ||
module Terminatorable | ||
|
||
module ClassMethods | ||
|
||
def likes_to_protect(people=[]) | ||
["destroy", "protect"].each do |mission_type| | ||
people.each do |person| | ||
define_method "#{mission_type}_#{person}!" do | ||
@current_mission = "#{mission_type}: #{person}" | ||
define_method "protect_#{person}!" do | ||
@current_mission = "protect: #{person}" | ||
end | ||
end | ||
end | ||
|
||
def likes_to_destroy(people=[]) | ||
people.each do |person| | ||
define_method "destroy_#{person}!" do | ||
@current_mission = "destroy: #{person}" | ||
end | ||
end | ||
end | ||
end | ||
|
||
|
||
end | ||
|
||
def self.included(klass) | ||
attr_reader :current_mission | ||
attr_reader :current_mission, :good | ||
klass.extend Terminatorable::ClassMethods | ||
end | ||
|
||
def protects?(person) | ||
methodize = "protect_#{person.downcase!.sub(' ','_')}!" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice touch! |
||
self.respond_to?(methodize) | ||
end | ||
|
||
def good? | ||
@current_mission[0..7] == 'protect:' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd probably go with a regex in Ruby for something like this: @current_mission ~= /^protect:/ |
||
end | ||
|
||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poor bob :)