Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new javametrics summary tab in graphmetrics. #36

Merged
merged 3 commits into from
Oct 31, 2017

Conversation

hhellyer
Copy link
Member

  • Re-use the env table as a general purpose text
    table and move to a more OO design to make it
    easier to move classes around.
  • Re-work the httpTop5.js table so it can be moved
    to another tab.
  • Change all the graphs so when they maximise they
    only change the graphs on the same tab as themselves.

- Re-use the env table as a general purpose text
  table and move to a more OO design to make it
  easier to move classes around.
- Re-work the httpTop5.js table so it can be moved
  to another tab.
- Change all the graphs so when they maximise they
  only change the graphs on the same tab as themselves.
@codecov-io
Copy link

codecov-io commented Oct 31, 2017

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           1      1           
=====================================
  Hits            1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db242e6...d12bb10. Read the comment docs.

Copy link
Member

@tobespc tobespc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobespc tobespc merged commit e5c1243 into RuntimeTools:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants