Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled async while parsing items inside trait #2778

Closed
braw-lee opened this issue Dec 15, 2023 · 3 comments · Fixed by #2779
Closed

Unhandled async while parsing items inside trait #2778

braw-lee opened this issue Dec 15, 2023 · 3 comments · Fixed by #2779
Labels
bug

Comments

@braw-lee
Copy link
Contributor

error
compiler does not recognize async as a keyword which is bug
@braw-lee braw-lee added the bug label Dec 15, 2023
braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 15, 2023
@braw-lee
Handle async qualifier inside trait
c4b74a5 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` similar to `const`
	(Parser::parse_pattern): clang-format.

Signed-off-by: Kushal Pal <[email protected]>
@braw-lee braw-lee mentioned this issue Dec 15, 2023
Merged
braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 15, 2023
@braw-lee
Handle async qualifier inside trait
0187d64 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` similar to `const`

Signed-off-by: Kushal Pal <[email protected]>
braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 15, 2023
@braw-lee
Handle async qualifier inside trait
72c7e45 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` similar to `const`

Signed-off-by: Kushal Pal <[email protected]>
@braw-lee
Copy link
Contributor Author

I want to fix #2767 which will build upon this commit, should I wait for this PR to be merged and create a new PR for that issue
or do you want me to handle that issue in this PR?
@P-E-P

@P-E-P
Copy link
Member

P-E-P commented Dec 16, 2023

I want to fix #2767 which will build upon this commit, should I wait for this PR to be merged and create a new PR for that issue
or do you want me to handle that issue in this PR?
@P-E-P

We try to keep PRs short to make them easy to review. Usually when some changes depend on a given open PR people write something such as depends on #XXXX and keep the second PR in draft until the first one is accepted. They rebase the second PR on master once the first one is merged. We won't reject a PR because it solves two issues though.

@braw-lee
Copy link
Contributor Author

ok thanks,
since the commits were related and really small I add commits to same PR

braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 27, 2023
@braw-lee
Handle async qualifier inside trait
7cb0591 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` items

Signed-off-by: Kushal Pal <[email protected]>
braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 27, 2023
@braw-lee
Handle async qualifier inside trait
84ba175 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` items

Signed-off-by: Kushal Pal <[email protected]>
braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 27, 2023
@braw-lee
Handle async qualifier inside trait
eb15fb6 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` items

Signed-off-by: Kushal Pal <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Dec 27, 2023
@braw-lee @CohenArthur
Handle async qualifier inside trait
b2e1131 
Fixes #2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` items

Signed-off-by: Kushal Pal <[email protected]>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 17, 2024
@braw-lee @CohenArthur
Handle async qualifier inside trait
a722811 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` items

Signed-off-by: Kushal Pal <[email protected]>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 26, 2024
@braw-lee @CohenArthur
Handle async qualifier inside trait
3973664 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` items

Signed-off-by: Kushal Pal <[email protected]>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 26, 2024
@braw-lee @CohenArthur
gccrs: Handle async qualifier inside trait
70a2c4b 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` items

Signed-off-by: Kushal Pal <[email protected]>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Feb 5, 2024
@braw-lee @CohenArthur
gccrs: Handle async qualifier inside trait
bffceda 
Fixes Rust-GCC#2778

gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_trait_impl_item):
	Handled `async` items

Signed-off-by: Kushal Pal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle async qualifier inside trait braw-lee/gccrs
2 participants
@P-E-P @braw-lee