Implement SDL_UpperBlit as Surface.upper_blit

[gmorenz]

Contributes to #13

[andelf]

An Option<&Rect> is the same size & layout as a *Rect.
You can use mem::transmute(former cast::trasmute) to convert a Option<&Rect> to a nullable *Rect directly.
Option<Rect> => .as_ref() => Option<&Rect> => transmute() => *Rect

[gmorenz]

Thanks, I thought there should be a better way to do this but couldn't find it.

[andelf]

😄

[AngryLawyer]

I'm always happiest when contributors on a project I'm maintaining are smarter than me :D

Let me know when you're happy for this to be merged

[gmorenz]

This can be merged as soon as #100 is merged, I tested on a branch with andelf's pull request to simplify things on my side.

[gmorenz]

I just noticed that SDL_UpperBlit has been replaced with SDL_BlitSurface according to the documentation... despite the fact that SDL_BlitSurface is actually just #defined to SDL_UpperBlit in the implementation, as such I have changed the name of this method from upper_blit to blit_surface, other then that this pull request can be merged any time now that #100 has been merged.

[andelf]

How about naming it .blit()?
for e.g. UnlockSurface => Surface.unlock()

[AngryLawyer]

Yeah, I'd like just blit, then I'm happy for the merge :)

[jcmoyer]

+1 for blit.

[AngryLawyer]

Cheers for this! Sorry for not merging sooner, I've been on holiday.