Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flags.rs with stdlib bitflags macro #103

Merged
merged 1 commit into from
May 15, 2014
Merged

Replace flags.rs with stdlib bitflags macro #103

merged 1 commit into from
May 15, 2014

Conversation

jcmoyer
Copy link
Contributor

@jcmoyer jcmoyer commented May 15, 2014

Closes #96.

Breaking changes

  • The Flags trait is removed
    • Equivalent functionality can now be found on the bitflag types (eg Flags::none() is now FlagType::empty() and Flags::all() is now FlagType::all())
  • Shl and Shr are no longer supported operations on bitflag types
  • The behavior of Not has changed. Instead of flipping all of the bits in the contained value, it only flips the bits that were used in the definition of the bitflag type.

@jcmoyer
Copy link
Contributor Author

jcmoyer commented May 15, 2014

Travis failure is due to an outdated version of rust.

@AngryLawyer
Copy link
Member

Wonderful

AngryLawyer added a commit that referenced this pull request May 15, 2014
Replace flags.rs with stdlib bitflags macro
@AngryLawyer AngryLawyer merged commit c54c09a into Rust-SDL2:master May 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use bitflags!() to replace flag.rs
2 participants