Changed ticks function from &mut self to &self.
#1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting error.
|
I think you're safe with changing that to a |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Changed ticks function from `&mut self` to `&self`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Currently, the ticks method requires a
&mut self, which this PR downgrades to a&self.Please let me know if I've made a mistake in my understanding here. I think
&selfshould be fairly benign; AFAIKticksdoesn't do anything mutable under the hood.What motivated this change is I can't check the elapsed
tickswhile I have a livingTimerobject due to the borrow checker. If I have missed a good reason this function is marked as mutable then please let me know.