Rename to Signer/Verifier; add 'digest' module #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some sweeping refactoring here which hopefully cleans up the project organization and helps simplify its implementation: - `Sign` => `Signer`, `Verify` => `Verifier` - Move all `digest`-related functionality under the `digest` module: - `signature::digest::Signer` - `signature::digest::Verifier` - Re-export `::digest::Digest` as `signature::digest::Digest` - Remove `Send` + `Sync` bounds on traits: if people wants these bounds they can add them themselves.
tarcieri
force-pushed
the
refactor-back-to-signer-verifier
branch
from
ae9e3b5 to
58b4b11
Compare
|
@newpavlov many of these things were your suggestions, so hopefully aside from the That said I'd like to go ahead and merge this and immediately open another PR to address the blanket impl stuff we've been trying to do in #9 and #10, so if you do have feedback hopefully I can address it there (or perhaps in a separate PR). |
|
Okay, #12 is up, and contains the changes these were a setup for. Hopefully that helps illustrate how simple it actually is, versus if all of these were done in the same PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sweeping refactoring here which hopefully cleans up the project organization and helps simplify its implementation:
Sign=>Signer,Verify=>Verifierdigest-related functionality under thedigestmodule:signature::digest::Signersignature::digest::Verifier::digest::Digestassignature::digest::DigestSend+Syncbounds on traits: if people wants these boundsthey can add them themselves.