chacha20: fix rng feature on big endian platforms
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't necessarily "broken" in that it doesn't really matter what endianness random data comes in, but this at least makes the RNG output consistent on big and little endian platforms.
|
Well, in some applications PRNG reproducibility is quite important, so I think it was "broken" in a certain sense. We probably should add BE tests to other RustCrypto crates as well. I also had one BE mistake once (we were using Travis at the time). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't necessarily "broken" in that it doesn't really matter what endianness random data comes in, but this at least makes the RNG output consistent on big and little endian platforms.