elliptic-curve: consolidate CurveArithmetic trait
#1196
Merged
+106
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
elliptic-curve/curve-arithmetic-trait
branch
from
8131fa1 to
810478b
Compare
Consolidates the following former three traits into a single trait: - `AffineArithmetic` - `ProjectiveArithmetic` - `ScalarArithmetic` It doesn't make sense to impl one of these traits without impl'ing them all, so this commit combines them into a single trait.
tarcieri
force-pushed
the
elliptic-curve/curve-arithmetic-trait
branch
from
810478b to
921a4f9
Compare
Merged
sorah
added a commit
to sorah/needroleshere
that referenced
this pull request
Nov 4, 2023
Resolve incompatibilities as follows: - src/certificate.rs: RustCrypto/formats#771 - src/cmd/serve.rs: Move to FromRequestParts and use headers crate - src/ecdsa_sha256.rs: RustCrypto/traits#1196 and RustCrypto/signatures#574 - src/error.rs: Remove Duplicates - src/identity.rs: Remove owned validation logic as it should be done at x509_cert::serial_number::SerialNumber<x509_cert::certificate::Rfc5280> - src/sign.rs: RustCrypto/RSA#244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates the following former three traits into a single trait:
AffineArithmeticProjectiveArithmeticScalarArithmeticIt doesn't make sense to impl one of these traits without impl'ing them all, so this commit combines them into a single trait.