Mark preview feature as unstable in Cargo.toml #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrmm, the build is green on Travis CI, but it seems reporting isn't working or something? (I've been having various other problems with it this morning) Anyway, this looks good to me, thanks! |
Merged
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
Implements the PHC string format for hashes, currently gated under the `include_simple` cargo feature. Specifics of how the format is encoded/decoded are modeled off of the implementation of PHC hashes for PBKDF2 implemented by Auth0. See this thread for more information: https://community.auth0.com/t/bulk-user-import-custom-password-hash-issue/47408/5
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
The previous "simple" API used an MCF hash format (`$rpbkdf2$...`) which is unique to this crate and therefore not interoperable. As of RustCrypto#82, the PHC string format is supported, which provides an interoperable way to serialize PBKDF2 password hashes. This commit completely replaces the old "simple" API with the `password-hash` crate which supports the PHC string format as well as an impl of the `McfHasher` trait which supports verifying and upgrading hashes in the previous MCF format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I (and I'm sure a few others) often look at the Cargo.toml to find out what a crate's features are. It might be a good idea to explicitly point out there that the preview features are unstable.