Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

完成 router-store 和 完成 Devtool 的翻译 #1

Merged
merged 8 commits into from
Mar 9, 2018
Merged

完成 router-store 和 完成 Devtool 的翻译 #1

merged 8 commits into from
Mar 9, 2018

Conversation

WallenHan
Copy link
Member

router-store 的 readme api
Devtool 的 readme

@SangKa SangKa requested a review from xuxusheng December 15, 2017 04:45
@SangKa
Copy link
Member

SangKa commented Dec 15, 2017

@WallenHan 辛苦了
@xuxusheng 负责校对下吧

@xuxusheng
Copy link
Contributor

好的

SangKa
SangKa reviewed Dec 15, 2017
View reviewed changes
docs/router-store/README.md Outdated
@@ -2,20 +2,34 @@

Bindings to connect the Angular Router with @ngrx/store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看原文中的英文都还保留着，是为了方便校对吗？校对完再全部删掉？
最后原文是要全部替换成中文的

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不带英文感觉更好，直接 diff 做校对，这样就不用之后再删了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同意 @xuxusheng

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前参与 react 中文翻译的时候 保留的习惯，他们是中英对照的。

xuxusheng
xuxusheng reviewed Dec 15, 2017
View reviewed changes
docs/router-store/README.md Outdated
- `ROUTER_CANCEL` and `ROUTER_ERROR` contain the store state before the navigation. Use the previous state to restore the consistency of the store.
- `ROUTER_CANCEL` 和 `ROUTER_ERROR` 导航之前的 `store` 状态。 使用上一个状态来恢复 `store` 的一致性。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WallenHan ，这个感觉有点生硬~
ROUTER_CANCEL 和 ROUTER_ERROR 中包含了开始导航前的 store 状态，可以通过使用之前的状态来维持store的前后一致性。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少打字了，就是你说的意思 😭

xuxusheng
xuxusheng reviewed Dec 15, 2017
View reviewed changes
docs/router-store/api.md Outdated
To use the time-traveling debugging in the Devtools, you must return an object containing the `url` when using the `routerReducer`.

想要在开发工具中使用时光穿梭功能的话，你必须在使用 `routerReducer` 时返回一个包含 `url` 对象。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WallenHan
是不是少了个“的”字，包含url的对象~

docs/store-devtools/README.md Outdated
### Instrumentation with the Chrome / Firefox Extension

### 使用火狐、谷歌浏览器的插件查看监测
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WallenHan

  1. 用浏览器扩展比浏览器插件要更标准一点，在 chrome 的开发者文档中，extension 和 plugin 指的是不一样的东西。
  2. 查看监测是不是有点生硬~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我也没找到更合适的词语。 有疑问的地方你先改下 届时在看效果

docs/store-devtools/README.md Outdated
#### `maxAge`
number (>1) | false - maximum allowed actions to be stored in the history tree. The oldest actions are removed once maxAge is reached. It's critical for performance. Default is `false` (infinite).

`number` 型参数 或者 false - 配置允许存储在记录中的 `actions` 的最大值。达到最大值时，最早的 `action` 会被清除。 这个参数很影响性能。 默认值是 `false` ( 无限大)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WallenHan
number 要大于一的意思没有了哦~

docs/store-devtools/README.md Outdated
#### `name`
string - the instance name to be showed on the monitor page. Default value is _NgRx Store DevTools_.

`string` 型参数 展示在仪表 监控面板上的实例名字。 默认是 _NgRx Store DevTools_ 。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WallenHan
string 型参数感觉有点生硬，直接使用 string 类型 或者 字符串类型，或者干脆直接 string 不要翻译会不会更好点？

@WallenHan
Copy link
Member Author

@SangKa @xuxusheng 我已经提交了 单中文版本并以按照意见修改部分语言。

@WallenHan
Copy link
Member Author

已解决冲突

@WallenHan
Merge pull request #1 from RxJS-CN/master
cb8dd8d 
合并最新的官方版本
@xuxusheng
Copy link
Contributor

可以了，挺不错的， @SangKa

@xuxusheng xuxusheng closed this Mar 9, 2018
@xuxusheng xuxusheng reopened this Mar 9, 2018
SangKa
SangKa approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@SangKa SangKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两位辛苦了

@SangKa SangKa merged commit 2b93e82 into RxJS-CN:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuxusheng xuxusheng xuxusheng left review comments

@SangKa SangKa SangKa approved these changes

Assignees
No one assigned
Labels
state: complete reivew state: wait to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WallenHan @SangKa @xuxusheng