Skip to content

Commit

Permalink
Update react/http compatible versions
Browse files Browse the repository at this point in the history
  • Loading branch information
mbonneau committed Apr 29, 2023
1 parent 33325a9 commit 10f8373
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
os:
- ubuntu-20.04
php:
- 8.1
- 8.0
- 7.4
- 7.3
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
]
},
"require": {
"react/http": "^1",
"react/http": "1.5.* | 1.6.* | 1.7.* | 1.8.*",

This comment has been minimized.

Copy link
@WyriHaximus

WyriHaximus Apr 30, 2023

Contributor

@mbonneau Did we break anything in 1.9 for this package?

This comment has been minimized.

Copy link
@mbonneau

mbonneau May 2, 2023

Author Member

Apparently I am using an internal class React\Http\Client\Client and did not realize it and the constructor arguments changed.

This comment has been minimized.

Copy link
@WyriHaximus

WyriHaximus May 3, 2023

Contributor

Let me have a look to see if I can migrate it to the browser class, and if not how to resolve this.

This comment has been minimized.

Copy link
@WyriHaximus

WyriHaximus May 23, 2023

Contributor

Just filed #21 to resolve this, will ping you there when it's ready for review

"voryx/event-loop": "^3.0 || ^2.0.2",
"ratchet/rfc6455": "^0.3",
"reactivex/rxphp": "^2.0.1"
Expand Down

0 comments on commit 10f8373

Please sign in to comment.