Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Carthage main build project through Xcodegen #173

Closed
rynecheow opened this issue May 23, 2020 · 0 comments
Closed

Generate Carthage main build project through Xcodegen #173

rynecheow opened this issue May 23, 2020 · 0 comments
Assignees
@rynecheow
Labels
enhancement
Milestone
5.3.0

Comments

@rynecheow
Copy link
Member

Pros:

  • Better consistency over project structure for multi platform support
  • Better consistency as project.xcodeproj will be regenerated every build and relies on project.yml as source of truth
@rynecheow rynecheow self-assigned this May 23, 2020
@rynecheow rynecheow added this to the 5.3.0 milestone May 23, 2020
rynecheow added a commit that referenced this issue May 23, 2020
@rynecheow
feat(#173): Regenerate project
3470e0a 
Signed-off-by: Ryne Cheow <[email protected]>
rynecheow added a commit that referenced this issue May 24, 2020
@rynecheow
feat(#173): Implement danger and improve PR pipeline
10e4e14 
Signed-off-by: Ryne Cheow <[email protected]>
rynecheow added a commit that referenced this issue May 24, 2020
@rynecheow
feat(#173): Implement danger and improve PR pipeline
f980cbe 
Signed-off-by: Ryne Cheow <[email protected]>
rynecheow added a commit that referenced this issue May 24, 2020
@rynecheow
feat(#173): Regenerate project
a90c029 
Signed-off-by: Ryne Cheow <[email protected]>
rynecheow added a commit that referenced this issue May 24, 2020
@rynecheow
feat(#173): Implement danger and improve PR pipeline
e1d8ff8 
Signed-off-by: Ryne Cheow <[email protected]>
rynecheow added a commit that referenced this issue May 25, 2020
@rynecheow
feat(#173): Regenerate project
afc06de 
Signed-off-by: Ryne Cheow <[email protected]>
rynecheow added a commit that referenced this issue May 25, 2020
@rynecheow
feat(#173): Implement danger and improve PR pipeline
94bbc31 
Signed-off-by: Ryne Cheow <[email protected]>
rynecheow added a commit that referenced this issue May 25, 2020
@rynecheow
feat(#173): Regenerate project
ebbfdbe 
Signed-off-by: Ryne Cheow <[email protected]>
rynecheow added a commit that referenced this issue May 25, 2020
@rynecheow
feat(#173): Implement danger and improve PR pipeline
c75b0ef 
Signed-off-by: Ryne Cheow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rynecheow rynecheow

Labels
enhancement
Projects
None yet
Milestone
5.3.0
Development

No branches or pull requests
1 participant
@rynecheow