[Bug] Doesn't Import External PDF if URL Contains One of " \ / < > : | ?

[alteredorange]

Steps to reproduce

1. Go to https://scholarsarchive.byu.edu/cgi/viewcontent.cgi?article=4092&context=byusq
2. Try to import his pdf into obsidian as an external pdf.
3. Dragging or using the bookmarklet function doesn't work.

Expected behavior

The PDF is imported as an external PDF.

Actual behavior

Nothing happens. It seems the plugin doesn't recognize PDFs unless there is a .pdf in the URL.

Screen recordings or screenshots

See below.

Obsidian debug info

N/A

PDF++ debug info

N/A

Error messages

Actually form the error message, it might be because the url has "?article", not necessarily that it doesn't have .pdf?

[alteredorange]

Ah definitely looks like the url containing "?article" is the problem, because If I just create a .pdf file file named "test", and then put the url into the file, it works fine. Perhaps there can be an option so when Bookmarking you can choose a name, or have it default to "new clip" or whatever.

[RyotaUshio]

@alteredorange

For drag-drop: you can use this option to customize what URL will be recognized as PDF. For example, .* means every URL should be considered as PDF.

obsidian://pdf-plus?setting=externalURIPatterns

For bookmarklet: I think the bookmarklet needs to be updated so that the "?article" part will be properly encoded.

[alteredorange]

@RyotaUshio it also fails when drag and dropping. The main issue is trying to name the file part of the url, because the url contains "?" which obsidian doesn't allow in a filename (i.e. "Library/Inbox/viewcontent.cgi?article=358.pdf"). So even when I drag and drop, I get the same error:

[RyotaUshio]

The bookmarklet on the documentation website has been updated.

As for drag-drop: as you said "?" is forbidden, you are likely to be on Windows, right? https://stackoverflow.com/questions/1976007/what-characters-are-forbidden-in-windows-and-linux-directory-names

I'm on mac so I didn't notice "?" in a file name was the problem. (This is why you have to fill in the Obsidian debug info section you ignored!)

I will add some logic to sanitize file names.

[RyotaUshio]

Will be fixed in 0.40.22

[alteredorange]

@RyotaUshio Windows strikes again! Thanks, sorry for the lack of debug info! And thanks for the awesome plugin!