Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New macOS icon #381

Merged
merged 2 commits into from
Dec 14, 2024
Merged

New macOS icon #381

merged 2 commits into from
Dec 14, 2024

Conversation

matthew-5pl
Copy link
Contributor

icon_256x256

This pull request makes the macOS icon fit in more with other modern macOS apps.
I tried to follow the design guidelines from Apple, but feedback is definitely appreciated! :)

Here's a read-only link to a Figma file with the design: Ryujinx macOS Icon

I had to manually export an appropriately sized bitmap version of the original logo, as Figma would render the gradient incorrectly (using a soft gradient rather than rendering color segments).

@github-actions github-actions bot added the infra Updates to dependencies label Dec 13, 2024
@matthew-5pl
Copy link
Contributor Author

I got the label wrong, it's supposed to be macOS 🫡

@GreemDev
Copy link
Member

icon_256x256

This pull request makes the macOS icon fit in more with other modern macOS apps. I tried to follow the design guidelines from Apple, but feedback is definitely appreciated! :)

Here's a read-only link to a Figma file with the design: Ryujinx macOS Icon

I had to manually export an appropriately sized bitmap version of the original logo, as Figma would render the gradient incorrectly (using a soft gradient rather than rendering color segments).

Frankly I like it. If you're happy with it as is I am too. The .icns file is the one shown in the image in the PR right? I can't view that file on Windows lol

@GabCoolDude

This comment was marked as resolved.

@GabCoolDude
Copy link
Collaborator

Just had a look at the icons in macOs, they look good.
However your svg is still broken for some reason, even not in the github preview it shows something else.

@GreemDev
Copy link
Member

Just had a look at the icons in macOs, they look good. However your svg is still broken for some reason, even not in the github preview it shows something else.

It seems like the Figma "Copy as SVG" functionality is either broken, or SVG doesn't support however the effect was done

@GabCoolDude
Copy link
Collaborator

I managed to fix the .svg being wrong using Adobe Illustrator, but the svg it produces is 2 MB, so im not going to add it.

@matthew-5pl
Copy link
Contributor Author

@GreemDev Yeah, it's the same icon :) I'm pretty satisfied with it, so feel free to merge :P

@GreemDev
Copy link
Member

@GreemDev Yeah, it's the same icon :) I'm pretty satisfied with it, so feel free to merge :P

I am too, so much that I've already gone through and changed it on other OSes in an uncommitted change :P

@GreemDev GreemDev merged commit d7d4225 into Ryubing:master Dec 14, 2024
10 checks passed
GreemDev added a commit that referenced this pull request Dec 14, 2024
@GabCoolDude GabCoolDude mentioned this pull request Dec 18, 2024
GreemDev pushed a commit that referenced this pull request Dec 19, 2024
GreemDev added a commit that referenced this pull request Dec 19, 2024
marco-carvalho pushed a commit to marco-carvalho/Ryujinx-1 that referenced this pull request Jan 5, 2025
marco-carvalho pushed a commit to marco-carvalho/Ryujinx-1 that referenced this pull request Jan 5, 2025
@pleasejustgo

This comment was marked as spam.

@matthew-5pl
Copy link
Contributor Author

how is this logo better than the original? All you did was make a border and then changed the colours to rainbow instead of blue and red. How is that better? Because it's more inclusive? More pandering to identity politics playing psychos. Gay s**t.

First of all, this fork's logo was already rainbow colored before I edited it. If you bothered to actually read the PR, you'd see that I initially proposed this icon for macOS only, since it's meant to match the design guidelines for macOS app icons.

Second of all, if a rainbow scares you that much, I'd recommend steering clear of this project, you wouldn't want the gays to ruin your emulation experience, would you?

Sincerely, the gay guy who made this icon 💞

@GreemDev
Copy link
Member

GreemDev commented Jan 7, 2025

how is this logo better than the original? All you did was make a border and then changed the colours to rainbow instead of blue and red. How is that better? Because it's more inclusive? More pandering to identity politics playing psychos. Gay s**t.

If you did even the slightest bit of research (which you idiot homophobes never do) you'd realize they aren't the one who made it rainbow. I did. It's been that way for months. Now kindly fuck off. Blocked from the repo. Get a fucking grip on reality you hateful asshole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Updates to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants