Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTERS WANTED: RyuLDN implementation #65

Merged
merged 16 commits into from
Nov 11, 2024
Merged

Conversation

Vudjun
Copy link
Contributor

@Vudjun Vudjun commented Oct 25, 2024

These changes allow players to matchmake for local wireless using a LDN server. The network implementation originates from Berry's public TCP RyuLDN fork. Logo and unrelated changes have been removed.

Additionally displays LDN game status in the game selection window when RyuLDN is enabled.

Functionality is only enabled while network mode is set to "RyuLDN" in the settings.

If you're just here to download the LDN build, get the canary release here

@github-actions github-actions bot added gpu Affects GPU emulation graphics-backend:opengl Affects the OpenGL Graphics backend graphics-backend:vulkan Affects the Vulkan Graphics backend gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components. infra Updates to dependencies labels Oct 25, 2024
@GreemDev GreemDev self-assigned this Oct 26, 2024
@Maskworkr
Copy link

Ryujinx_1.2.0+97da30d_2024-10-26_00-17-47.log
Ryujinx_1.2.0+97da30d_2024-10-25_23-59-19.log

so far so good, played couple laps on MK8DX 3.03 connection to wireless was smooth, only me and another person was in the lobby, there were no visual rubberbanding or any internet latency problems, gameplay was good for me.

@Vbuck-gang
Copy link

Ryujinx_1.2.0+97da30d_2024-10-26_00-34-46.log

i tried to create a room in Mario party superstars but after i try it crashes while doing the connection process

@Maskworkr
Copy link

Maskworkr commented Oct 26, 2024

Ryujinx_1.2.0+97da30d_2024-10-26_00-34-46.log
i tried to create a room in Mario party superstars but after i try it crashes while doing the connection process

Ryujinx_1.2.0+97da30d_2024-10-26_00-40-01.log
tried to join a room, found no room and sent me back to menu, then i created a room and it created normally and finding other players to join the room without any problem or crashes on me

@Vbuck-gang
Copy link

Vbuck-gang commented Oct 26, 2024

strange, i tried 3 times before and it didn't work but after maskworkr commented it just magically started working for me.

@OldManKain
Copy link

Tested this tonight, and it works.
image

@GreemDev GreemDev added ldn Affects the LDN functionality and removed gpu Affects GPU emulation graphics-backend:opengl Affects the OpenGL Graphics backend graphics-backend:vulkan Affects the Vulkan Graphics backend labels Oct 26, 2024
@GreemDev GreemDev changed the title RyuLDN implementation TESTERS WANTED: RyuLDN implementation Oct 26, 2024
@Vbuck-gang
Copy link

smash ultimate works just fine
Screenshot (148)

@LiriRaid
Copy link

@Vbuck-gang How did you manage to play Super Smash Ultimate in online mode? I'm trying but it won't let me?

@Vbuck-gang
Copy link

@LiriRaid maybe your internet is the problem? I'm willing to start a Smash Ultimate match with you just to test it out since i have 600mb down. this will let you know if it's just your internet or not.

@GreemDev
Copy link
Member

@LiriRaid maybe your internet is the problem? I'm willing to start a Smash Ultimate match with you just to test it out since i have 600mb down. this will let you know if it's just your internet or not.

Based on the conversation in the Discord it seems like they were trying to play online instead of LAN, which would be the reason, as LDN is LAN emulation, not NSO emulation

@Vbuck-gang
Copy link

oh yeah that's not general knowledge yet

The network implementation originates from Berry's public TCP RyuLDN fork. Logo and unrelated changes have been removed.

Additionally displays LDN game status in the game selection window when RyuLDN is enabled.
@NhProGamer
Copy link

i tested the parameters in the UI and in headless mode and it works

@JoJoelix
Copy link

JoJoelix commented Nov 5, 2024

Ryujinx_1.2.0+7a39ffa_2024-11-05_18-12-28.log

some minor stutters and apparently audio problems according to the log. MHGU

@NhProGamer
Copy link

Ryujinx_1.2.0+7a39ffa_2024-11-05_18-12-28.log

some minor stutters and apparently audio problems according to the log. MHGU

not caused by LDN implementation, as for me i have 0 audio issues, same after 1h30 of playing

@HelloZero2000
Copy link

I installed a fresh and latest update of ryujinx 1.2.0+9079755 I setting up and done but I'm done and suddenly pop up

Minuet23

also here's the log:
Ryujinx_1.2.0+9079755_2024-11-06_09-22-50.log

@NhProGamer
Copy link

NhProGamer commented Nov 6, 2024

I installed a fresh and latest update of ryujinx 1.2.0+9079755 I setting up and done but I'm done and suddenly pop up

Minuet23

also here's the log: Ryujinx_1.2.0+9079755_2024-11-06_09-22-50.log

test with ldn.nhsoul.fr (u can use my server but i recommend you to use Vudjun server idk what is the dn) maybe you typed a bad ip or a bad dn

@Cerhidwen

This comment was marked as off-topic.

@GabCoolDude
Copy link
Collaborator

What you're talking about requires NSO (Nintendo Switch Online). This will never be implemented into ryujinx, because it would require a direct connection to Nintendo's servers, and, to do this without permission would be illegal.

@Cerhidwen

This comment was marked as off-topic.

@ewngz

This comment was marked as off-topic.

@NhProGamer

This comment was marked as off-topic.

@ewngz

This comment was marked as off-topic.

@ewngz

This comment was marked as off-topic.

@MetrosexualGarbodor

This comment was marked as off-topic.

@ewngz

This comment was marked as off-topic.

@GreemDev
Copy link
Member

Well well well! It's all finished it seems. I have no qualms merging this, and @Vudjun let me know it should be ready.
To those currently testing, I implore you to update to Canary! That's where this is going before it ends up in the main release.

@GreemDev GreemDev merged commit 6d8738c into Ryubing:master Nov 11, 2024
10 checks passed
@Copox
Copy link

Copox commented Nov 12, 2024

I noticed that enabling P2P communication requires UPnP, and if it’s not enabled, the connection falls back to using a master server as a proxy. I have a question regarding this: Is it possible for RyuLDN mode to support IPv6? This way, it seems like UPnP wouldn’t be necessary.

@Linx-ESP
Copy link

P2P only works with upnp (igd) not NAT-PMP, checked with my openwrt router.

support IPv6? This way, it seems like UPnP wouldn’t be necessary.

IPv6 removes NAT (in domestic context and whatever) but you still need a firewall rule to accept incoming connections.

@Copox
Copy link

Copox commented Nov 13, 2024

P2P only works with upnp (igd) not NAT-PMP, checked with my openwrt router.

support IPv6? This way, it seems like UPnP wouldn’t be necessary.

IPv6 removes NAT (in domestic context and whatever) but you still need a firewall rule to accept incoming connections.

As you described, my understanding is that I can use IPv6 to bypass RyuLDN's dependency on UPnP. Therefore, I need to know which ports RyuLDN requires so that I can configure the relevant firewall rules.

@Ryubing Ryubing locked as off-topic and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components. infra Updates to dependencies ldn Affects the LDN functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.