Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default settings.json - recaptcha exception if null #1234

Closed
davmlaw opened this issue Jan 22, 2025 · 1 comment
Closed

default settings.json - recaptcha exception if null #1234

davmlaw opened this issue Jan 22, 2025 · 1 comment

Comments

@davmlaw
Copy link
Contributor

davmlaw commented Jan 22, 2025

We should make this be turned off if the settings are empty, not crash:

  File "/home/dlawrence/localwork/variantgrid/env/lib/python3.12/site-packages/django_recaptcha/__init__.py", line 18, in <module>
    raise ImproperlyConfigured(
django.core.exceptions.ImproperlyConfigured: ('Setting RECAPTCHA_PRIVATE_KEY is not of type', <class 'str'>)
davmlaw added a commit that referenced this issue Feb 12, 2025

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
davmlaw added a commit that referenced this issue Feb 12, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@davmlaw
Copy link
Contributor Author

davmlaw commented Feb 12, 2025

Made the example settings_config.json values "" instead of null

This is not user-testable, deploy only for new systems

@davmlaw davmlaw closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant