Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сhange development flow #132

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Сhange development flow #132

merged 4 commits into from
Sep 30, 2024

Conversation

ku9nov
Copy link
Collaborator

@ku9nov ku9nov commented Sep 7, 2024

This pull request proposes a more user-friendly deployment of the application. In this case, we no longer need to use additional variables, such as RUN_SAMA=true. This is now managed through the Docker Compose override development file.

It also seems that this section of the README is no longer needed:

:warning: If you are using MacOS or Windows, and want run `SAMA` apps, add these two variables before the launch command:
MacOS

MINIO_ENDPOINT=$(ipconfig getifaddr en0) MINIO_PORT=9010


Windows


$env:MINIO_ENDPOINT = (Get-NetIPAddress | Where-Object { $_.AddressFamily -eq 'IPv4' -and $_.IPAddress -match '^192\.168\.|^10\.|^172\.(1[6-9]|2[0-9]|3[0-1])\.' } | Select-Object -ExpandProperty IPAddress)[1]; $env:MINIO_PORT = 9010;


If you are encountering issues with attachments in the web client, it suggests that an error occurred in the first variable. To resolve this, you can simply update the code segment with the private IP address of your machine.

During testing on MacOS, it was not necessary to set these variables, so it should be checked on Windows.

It's also worth noting that I didn't change this part:

To build and run the `SAMA` with all dependencies, you can use the following command:

docker-compose -f docker-compose-full.yml up --build

I believe no variability is needed for this file.
Let me know if anything needs to be changed or improved.

@IgorKhomenko IgorKhomenko merged commit 26d3eb7 into main Sep 30, 2024
@IgorKhomenko IgorKhomenko deleted the feature/new-dev-flow branch September 30, 2024 07:42
Oleksandr1414 added a commit that referenced this pull request Oct 23, 2024
* Release 0.25.0 (#123)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Release 0.25.0 (#124)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Updated tests for status typing (removed tests for deleted fields)

* Update API.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* updated package.json

* Update README.md

* Сhange development flow (#132)

* FM-27 added `device_token` for push subscription

* FM-27 minor cleanup

* FM-27 removed `rsmq-promise`, updated bull queue  methods

* FM-27 renamed minor comments

---------

Co-authored-by: IgorKhomenko <[email protected]>
Co-authored-by: Igor Khomenko <[email protected]>
Co-authored-by: ku9nov <[email protected]>
Oleksandr1414 added a commit that referenced this pull request Oct 24, 2024
* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Updated tests for status typing (removed tests for deleted fields)

* FM-27 added device_token for push subscription (#136)

* Release 0.25.0 (#123)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Release 0.25.0 (#124)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Updated tests for status typing (removed tests for deleted fields)

* Update API.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* updated package.json

* Update README.md

* Сhange development flow (#132)

* FM-27 added `device_token` for push subscription

* FM-27 minor cleanup

* FM-27 removed `rsmq-promise`, updated bull queue  methods

* FM-27 renamed minor comments

---------

Co-authored-by: IgorKhomenko <[email protected]>
Co-authored-by: Igor Khomenko <[email protected]>
Co-authored-by: ku9nov <[email protected]>

* updated CHANGELOG.md

* renamed env file

---------

Co-authored-by: IgorKhomenko <[email protected]>
Co-authored-by: Igor Khomenko <[email protected]>
Co-authored-by: ku9nov <[email protected]>
Oleksandr1414 added a commit that referenced this pull request Oct 24, 2024
* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Updated tests for status typing (removed tests for deleted fields)

* FM-27 added device_token for push subscription (#136)

* Release 0.25.0 (#123)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Release 0.25.0 (#124)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Updated tests for status typing (removed tests for deleted fields)

* Update API.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* updated package.json

* Update README.md

* Сhange development flow (#132)

* FM-27 added `device_token` for push subscription

* FM-27 minor cleanup

* FM-27 removed `rsmq-promise`, updated bull queue  methods

* FM-27 renamed minor comments

---------

Co-authored-by: IgorKhomenko <[email protected]>
Co-authored-by: Igor Khomenko <[email protected]>
Co-authored-by: ku9nov <[email protected]>

* updated CHANGELOG.md

* renamed env file

* updated tests for `push_subcriptions`, added indexes for the `push_subcriptions` collection

---------

Co-authored-by: IgorKhomenko <[email protected]>
Co-authored-by: Igor Khomenko <[email protected]>
Co-authored-by: ku9nov <[email protected]>
Oleksandr1414 added a commit that referenced this pull request Nov 5, 2024
* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Updated tests for status typing (removed tests for deleted fields)

* FM-27 added device_token for push subscription (#136)

* Release 0.25.0 (#123)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Release 0.25.0 (#124)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Updated tests for status typing (removed tests for deleted fields)

* Update API.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* updated package.json

* Update README.md

* Сhange development flow (#132)

* FM-27 added `device_token` for push subscription

* FM-27 minor cleanup

* FM-27 removed `rsmq-promise`, updated bull queue  methods

* FM-27 renamed minor comments

---------

Co-authored-by: IgorKhomenko <[email protected]>
Co-authored-by: Igor Khomenko <[email protected]>
Co-authored-by: ku9nov <[email protected]>

* updated CHANGELOG.md

* renamed env file

* updated tests for `push_subcriptions`, added indexes for the `push_subcriptions` collection

* SK-273 remove `platform` field from pushEvent object (#141)

* SK-272 extended `conversation_list` request to allow request convs by ids (#142)

* SK-272 added `ids` options for conversation_list, added test, updated API.md

* SK-272 added limit for ids field - 10

* SK-272 updated API.md

* Updated CHANGELOG.md

* Fixes different naming of methods

---------

Co-authored-by: IgorKhomenko <[email protected]>
Co-authored-by: Igor Khomenko <[email protected]>
Co-authored-by: ku9nov <[email protected]>
Oleksandr1414 added a commit that referenced this pull request Nov 5, 2024
* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Updated tests for status typing (removed tests for deleted fields)

* FM-27 added device_token for push subscription (#136)

* Release 0.25.0 (#123)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Release 0.25.0 (#124)

* SK-217 Implemented group chat images  (#117)

* SK-189 added `avatar_object` field for user object

* SK-189 implemented the logic of creating links for downloading user avatars

* SK-189 renamed downloadFile to getFileDownloadUrl

* SK-217 added `image_object` for Conversation fields

* SK-217 added `image_url` field to the system event

* SK-217 added sending update request to other users

* SK-217 cleanup

* SK-217 minor fix

* SK-217 added image_object for conversationCreate

* SK-217 add log

* SK-217 remove log

* SK-217 add log

* SK-217 remove log

* SK-194 updated `typing` object (#121)

* Sk-194 updated typing object

* SK-194 updated API.md

* SK-234 removed file name from uuid in file `object_id` (#122)

* updated CHANGELOG.md (0.24.0 -> 0.25.0)

* Updated tests for status typing (removed tests for deleted fields)

* Update API.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* updated package.json

* Update README.md

* Сhange development flow (#132)

* FM-27 added `device_token` for push subscription

* FM-27 minor cleanup

* FM-27 removed `rsmq-promise`, updated bull queue  methods

* FM-27 renamed minor comments

---------

Co-authored-by: IgorKhomenko <[email protected]>
Co-authored-by: Igor Khomenko <[email protected]>
Co-authored-by: ku9nov <[email protected]>

* updated CHANGELOG.md

* renamed env file

* updated tests for `push_subcriptions`, added indexes for the `push_subcriptions` collection

* SK-273 remove `platform` field from pushEvent object (#141)

* SK-272 extended `conversation_list` request to allow request convs by ids (#142)

* SK-272 added `ids` options for conversation_list, added test, updated API.md

* SK-272 added limit for ids field - 10

* SK-272 updated API.md

* Updated CHANGELOG.md

* Fixes different naming of methods

* Updated CHANGELOG.md

---------

Co-authored-by: IgorKhomenko <[email protected]>
Co-authored-by: Igor Khomenko <[email protected]>
Co-authored-by: ku9nov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants