Do not append " | " to OneLogin::RubySaml::Response#status_code unnecessarily #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caioeps
changed the title
|
In my opinion, if we're returning multiple status codes we should probably be returning an array, not a string with a separator. As doing so could break existing code that relies on this behaviour I choose to keep it as is. |
pitbulk
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
OneLogin::RubySaml::Response#status_codeonly work as expected when we have multiple status codes in the response. When it has only one status code it is appending" | "unecessarily to the end.Steps to reproduce can be found on #584.