Skip to content

Commit

Permalink
8348040: Bad use of ifdef with INCLUDE_xxx GC macros
Browse files Browse the repository at this point in the history
Reviewed-by: stefank, shade
  • Loading branch information
David Holmes committed Jan 20, 2025
1 parent ca863fd commit 955bf18
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/hotspot/share/c1/c1_LIR.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2000, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2000, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -1016,7 +1016,7 @@ enum LIR_Code {
, begin_opAssert
, lir_assert
, end_opAssert
#ifdef INCLUDE_ZGC
#if INCLUDE_ZGC
, begin_opXLoadBarrierTest
, lir_xloadbarrier_test
, end_opXLoadBarrierTest
Expand Down
7 changes: 3 additions & 4 deletions src/hotspot/share/runtime/mutexLocker.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -52,7 +52,7 @@ Mutex* JvmtiThreadState_lock = nullptr;
Monitor* EscapeBarrier_lock = nullptr;
Monitor* JvmtiVTMSTransition_lock = nullptr;
Monitor* Heap_lock = nullptr;
#ifdef INCLUDE_PARALLELGC
#if INCLUDE_PARALLELGC
Mutex* PSOldGenExpand_lock = nullptr;
#endif
Mutex* AdapterHandlerLibrary_lock = nullptr;
Expand Down Expand Up @@ -333,7 +333,7 @@ void mutex_init() {
}

MUTEX_DEFL(CompileTaskAlloc_lock , PaddedMutex , MethodCompileQueue_lock);
#ifdef INCLUDE_PARALLELGC
#if INCLUDE_PARALLELGC
if (UseParallelGC) {
MUTEX_DEFL(PSOldGenExpand_lock , PaddedMutex , Heap_lock, true);
}
Expand Down Expand Up @@ -377,4 +377,3 @@ GCMutexLocker::GCMutexLocker(Mutex* mutex) {
_mutex->lock();
}
}

4 changes: 2 additions & 2 deletions src/hotspot/share/runtime/mutexLocker.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -49,7 +49,7 @@ extern Mutex* JvmtiThreadState_lock; // a lock on modification of JV
extern Monitor* EscapeBarrier_lock; // a lock to sync reallocating and relocking objects because of JVMTI access
extern Monitor* JvmtiVTMSTransition_lock; // a lock for Virtual Thread Mount State transition (VTMS transition) management
extern Monitor* Heap_lock; // a lock on the heap
#ifdef INCLUDE_PARALLELGC
#if INCLUDE_PARALLELGC
extern Mutex* PSOldGenExpand_lock; // a lock on expanding the heap
#endif
extern Mutex* AdapterHandlerLibrary_lock; // a lock on the AdapterHandlerLibrary
Expand Down

0 comments on commit 955bf18

Please sign in to comment.