Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: exclude cross-module references #5359

Closed
N1XUS opened this issue May 14, 2021 · 4 comments · Fixed by #5453
Closed

Core: exclude cross-module references #5359

N1XUS opened this issue May 14, 2021 · 4 comments · Fixed by #5453
Labels
core Core library specific issues enhancement New feature or request

Comments

@N1XUS
Copy link
Contributor

N1XUS commented May 14, 2021

Is this a bug, enhancement, or feature request?

feature request

Briefly describe your proposal.

We currently have inter-references between modules, which removes Tree-shake ability and eliminates the possibility of creating sub-packages for each module.

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

0.30

If this is a bug, please provide steps for reproducing it.

Please provide relevant source code if applicable.

Is there anything else we should know?

@dimamarksman
Copy link
Contributor

@N1XUS could you please be more specific? What modules are you talking about?

@N1XUS
Copy link
Contributor Author

N1XUS commented May 17, 2021

@dimamarksman majority of the modules are cross-referenced inside other modules. For example, dialog module dependencies:
image

@dimamarksman
Copy link
Contributor

@N1XUS thanks for your response.
Ideally, we have to create a separate issue for each particular case and fix it step by step

@dimamarksman dimamarksman added core Core library specific issues enhancement New feature or request labels May 17, 2021
@droshev
Copy link
Contributor

droshev commented May 19, 2021

@dimamarksman we can start with separating dialog and wizard #5402
How about platform? shall we run the same exercise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants