Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): split into libraries #5453

Merged
merged 19 commits into from
Jun 2, 2021

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented May 24, 2021

Please provide a link to the associated issue.

Closes #5359

Please provide a brief summary of this pull request.

Split core library into multiple sub-packages, while still keeping legacy way of imports.

  • Libraries are built with nx instead of ng;
  • All main core modules are now built as separate sub-packages;
  • Recommended way of importing files from the core library now is following:
import {DialogModule, DialogService} from '@fundamental-ngx/core/dialog';
  • Structure of fundamental-ngx/core was refactored to allow splitting it into separate sub-packages;
  • CarouselModule now in the Carousel namespace instead of utils;
  • AlertService, DialogService, NotificationService, MessageToastService, ThemesService are removed from providers array in FundamentalNgxCoreModule;
  • Core documentation has been updated with the appropriate import paths;
  • TSPath has been updated to reflect all separate submodules paths;
  • root tsconfig.json has been renamed to tsconfig.base.json;
  • tests folder from utils has been moved to a separate sub-package;
  • each library contains own tsconfig.json file with strict mode disabled, and can be enabled on per-package basis;
  • *.spec.ts files are excluded from dependency graph calculation for nx;
  • Now it is possible to launch module-specific unit tests by using nx test core-[module-name] command

Please check whether the PR fulfills the following requirements

Documentation checklist:

@N1XUS N1XUS requested a review from valorkin May 24, 2021 14:35
@N1XUS N1XUS requested review from droshev and fkolar as code owners May 24, 2021 14:35
@netlify
Copy link

netlify bot commented May 24, 2021

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 523d5e4

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60b544084f6688000717b3e7

😎 Browse the preview: https://deploy-preview-5453--fundamental-ngx.netlify.app

@N1XUS N1XUS removed request for droshev and fkolar May 24, 2021 14:51
@N1XUS N1XUS changed the title [WIP] feat: (Core) split into libraries feat: (Core) split into libraries. May 28, 2021
@platon-rov
Copy link
Contributor

Please resolve conflicts, provide some description, maybe relative issues.

@Betrozov Betrozov added core Core library specific issues documentation There is an issue with documentation labels May 28, 2021
@Betrozov Betrozov added this to the Sprint 63 - Ariba milestone May 28, 2021
@N1XUS
Copy link
Contributor Author

N1XUS commented May 28, 2021

Please resolve conflicts, provide some description, maybe relative issues.

Done. Thank you!

@platon-rov
Copy link
Contributor

Please fix Travis's unit tests.

@dimamarksman
Copy link
Contributor

These PR changes are so huge, it makes my chrome page unresponsive :(

@droshev droshev requested a review from a team May 31, 2021 10:17
@N1XUS
Copy link
Contributor Author

N1XUS commented May 31, 2021

Please fix Travis's unit tests.

Unit tests have been fixed.

@N1XUS
Copy link
Contributor Author

N1XUS commented May 31, 2021

These PR changes are so huge, it makes my chrome page unresponsive :(

I would suggest checking it locally. There are lots of minor changes like import paths, the most crucial part to check is the structure, configuration files, and namespace logic for the sub-packages.

@Betrozov Betrozov changed the title feat: (Core) split into libraries. feat(core): split into libraries Jun 2, 2021
@droshev droshev merged commit 54727a4 into main Jun 2, 2021
@droshev droshev deleted the feat/5359-remove-crossreference-and-subpackages branch June 2, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues documentation There is an issue with documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core: exclude cross-module references
7 participants