-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): split into libraries #5453
feat(core): split into libraries #5453
Conversation
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 523d5e4 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60b544084f6688000717b3e7 😎 Browse the preview: https://deploy-preview-5453--fundamental-ngx.netlify.app |
Please resolve conflicts, provide some description, maybe relative issues. |
Done. Thank you! |
Please fix Travis's unit tests. |
These PR changes are so huge, it makes my chrome page unresponsive :( |
Unit tests have been fixed. |
I would suggest checking it locally. There are lots of minor changes like import paths, the most crucial part to check is the structure, configuration files, and namespace logic for the sub-packages. |
Please provide a link to the associated issue.
Closes #5359
Please provide a brief summary of this pull request.
Split core library into multiple sub-packages, while still keeping legacy way of imports.
nx test core-[module-name]
commandPlease check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md