fix: refactor Action Bar title to follow the latest fund-styles #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit c11598d |
JKMarkowski
approved these changes
Sep 30, 2020
salarenko
suggested changes
Sep 30, 2020
There was a problem hiding this comment.
Why don't we use it like a custom element:
Like:
<fd-action-bar-title> Page Title </fd-action-bar-title>
Instead of:
<div fd-action-bar-title> Page Title </div>
div tag does not provide any additional semantic meaning, and I feel like it a bit complicating the markup.
salarenko
approved these changes
Sep 30, 2020
|
Lets discuss the directives later. |
droshev
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Part of #3420
Please provide a brief summary of this pull request.
In latest release of fundamental-styles the markup for Action Bar title is changes, also an additional class is added. The
fd-action-bar-titledirective is now a component.BREAKING CHANGE:
fd-action-bar-titledirective is now a component.Before:
After:
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist: