Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Core) unify the naming of the cozy property #3662

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Oct 21, 2020

Please provide a link to the associated issue.

close #3518

Please provide a brief summary of this pull request.

for the cozy property both cosy and cozy were used. It was decided that only cozy should be used. This PR is removing all the appearances of cosy in the Bar component and in the documentation examples.

BREAKING CHANGE:
In Bar component the Input property cosy was renamed to cozy for consistency with other components and Fiori 3 naming. Affected components: DateTime Picker, Dialog (footer and header).

Before:

<div fd-bar barDesign="footer" [cosy]="!compact">

Now:

<div fd-bar barDesign="footer" [cozy]="!compact">

Please check whether the PR fulfills the following requirements

Documentation checklist:

@InnaAtanasova InnaAtanasova added this to the Sprint 48 - Bora Bora milestone Oct 21, 2020
@InnaAtanasova InnaAtanasova requested a review from a team October 21, 2020 15:01
@InnaAtanasova InnaAtanasova self-assigned this Oct 21, 2020
@netlify
Copy link

netlify bot commented Oct 21, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 4abaeab

https://deploy-preview-3662--fundamental-ngx.netlify.app

@InnaAtanasova InnaAtanasova force-pushed the fix/unify-cozy-examples branch from 053243b to 4abaeab Compare October 21, 2020 15:19
@InnaAtanasova InnaAtanasova merged commit 2ffd49d into master Oct 22, 2020
@InnaAtanasova InnaAtanasova deleted the fix/unify-cozy-examples branch October 22, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify all 'cozy' / 'cosy' appearances.
2 participants