fix: (Core) adapt the Breaking Changes from fundamental-styles v.0.13.0 #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 06592b4 |
InnaAtanasova
force-pushed
the
fix/latest-migration-styles
branch
from
55c8949 to
bc58077
Compare
Betrozov
suggested changes
Nov 19, 2020
| @@ -1,7 +1,11 @@ | |||
| <header>Inline Help</header> | |||
| <description | |||
| >Inline help is used to display help text in a popover, often inline with headers, body text and form labels. It | |||
| also uses the fd-popover component and supports much of its functionality.</description | |||
| also uses the fd-popover component and supports much of its functionality. | |||
| <fd-message-strip [type]="'warning'" [dismissible]="false"> | |||
There was a problem hiding this comment.
unnecessary binding [type]="'warning'" => type="warning"
There was a problem hiding this comment.
fixed. Thanks for the catch
Betrozov
approved these changes
Nov 19, 2020
salarenko
approved these changes
Nov 20, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a brief summary of this pull request.
Address the breaking changes introduced in v.0.13.0 release of fundamental-styles.
form-selectfrom form controlPlease check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md