-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (Core) implement wizard summary #4082
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
5c8ad45
progress on responsive step stacking
mikerodonnell89 4bad32d
scrolling progress
mikerodonnell89 e9ba67d
more progress
mikerodonnell89 e5d7dae
fix flicker
mikerodonnell89 3a49526
tests
mikerodonnell89 9780e54
customizable content height
mikerodonnell89 57e8175
small tweaks
mikerodonnell89 ce817c7
programmatically set wizard content height
mikerodonnell89 a380921
fix custom contentHeight
mikerodonnell89 408c6a6
PR comments
mikerodonnell89 ffab446
force build
mikerodonnell89 d679e3b
fix build
mikerodonnell89 b3682dd
Merge branch 'master' into fix/wizard-scroll
mikerodonnell89 8a56957
fix scrollspy import
mikerodonnell89 205e253
pr comments
mikerodonnell89 b0fe079
fix conflict
mikerodonnell89 62b0a50
use action sheet
mikerodonnell89 71a42d3
pr comments
mikerodonnell89 8a6aa68
fix conflicts
mikerodonnell89 7e918b1
fix scrolling on mobile
mikerodonnell89 b9fea5e
Merge branch 'fix/wizard-scroll' into feat/wizard-stacked-step-popover-2
mikerodonnell89 dcf8acf
two more tiny tweaks
mikerodonnell89 d09065d
Merge branch 'fix/wizard-scroll' into feat/wizard-stacked-step-popover-2
mikerodonnell89 8271604
empty
mikerodonnell89 959c9ad
fix tests
mikerodonnell89 99594fc
fix conflicts
mikerodonnell89 645eaa9
fix tests
mikerodonnell89 a5959b9
fix build
mikerodonnell89 2ea2083
Merge branch 'master' into fix/wizard-summary-2
mikerodonnell89 97e53f7
progress on wizard summary - going back with edit buttons not working
mikerodonnell89 2bb967d
pr comments
mikerodonnell89 8c59efd
Merge branch 'fix/wizard-action-sheet' into fix/wizard-summary-2
mikerodonnell89 a4b6edb
some improvements
mikerodonnell89 3141be0
start on fullscreen thing
mikerodonnell89 a246823
improve wizard branching docs
mikerodonnell89 da43d16
Revert "start on fullscreen thing"
mikerodonnell89 5c0a390
conflicts
mikerodonnell89 96c51a9
case 1 and 2nd to last step submit button
mikerodonnell89 265f7d6
branching improvements
mikerodonnell89 3f0ed81
unused imports
mikerodonnell89 049ec97
fix scrolling issues, not being able to go back to summary page
mikerodonnell89 11ec460
Merge branch 'master' into fix/wizard-summary-2
mikerodonnell89 7649325
wizard branching dialog
mikerodonnell89 a95bdcd
fix connector
mikerodonnell89 24986d5
fix conflicts
mikerodonnell89 5190b0d
fix conflicts
mikerodonnell89 056699c
fix button hiding bug
mikerodonnell89 099b883
various bug fixes, full-screen examples
mikerodonnell89 26d169a
some improvements, mobile wizard progress bar not collapsing properly…
mikerodonnell89 e46561d
removeFromDom works on first load but not after visiting summary, goi…
mikerodonnell89 c20a83f
Merge branch 'master' into fix/wizard-summary-2
mikerodonnell89 93e33b7
fix stacking issue and layout grid on mobile
mikerodonnell89 90d44f3
prettier and add a little note about the summary page
mikerodonnell89 78d2a90
pr comments
mikerodonnell89 74acf64
more pr comments
mikerodonnell89 7bbd5ea
remove brackets
mikerodonnell89 5e915e5
Merge branch 'master' into fix/wizard-summary-2
mikerodonnell89 2ec478d
Merge branch 'main' into fix/wizard-summary-2
mikerodonnell89 eb434a7
Merge branch 'main' into fix/wizard-summary-2
mikerodonnell89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
198 changes: 112 additions & 86 deletions
198
.../docs/src/app/core/component-docs/wizard/examples/wizard-branching-example.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
122 changes: 70 additions & 52 deletions
122
...cs/src/app/core/component-docs/wizard/examples/wizard-customizable-example.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,53 +1,71 @@ | ||
<fd-wizard [appendToWizard]="false"> | ||
<fd-wizard-navigation> | ||
<ul fd-wizard-progress-bar size="sm"> | ||
<li fd-wizard-step [status]="step1status" (statusChange)="step1status = $event" label="Step 1: One Line"> | ||
<fd-wizard-step-indicator glyph="accept"></fd-wizard-step-indicator> | ||
<fd-wizard-content size="md" contentBackground="solid"> | ||
This wizard content has a 'solid' background and padding set with the size input. | ||
<fd-wizard-next-step> | ||
<button fd-button [compact]="true" fdType="emphasized" (click)="goToStep(2)"> | ||
Go to Step 2 | ||
</button> | ||
</fd-wizard-next-step> | ||
</fd-wizard-content> | ||
</li> | ||
<li | ||
fd-wizard-step | ||
[status]="step2status" | ||
(statusChange)="step2status = $event" | ||
label="Step 2: Another Step" | ||
> | ||
<fd-wizard-step-indicator>2</fd-wizard-step-indicator> | ||
<fd-wizard-content size="md"> | ||
Wizard Content for step 2 | ||
<fd-wizard-next-step> | ||
<button fd-button [compact]="true" fdType="emphasized" (click)="goToStep(3)"> | ||
Go to Step 3 | ||
</button> | ||
</fd-wizard-next-step> | ||
</fd-wizard-content> | ||
</li> | ||
<li | ||
fd-wizard-step | ||
[status]="step3status" | ||
(statusChange)="step3status = $event" | ||
label="Step 3: One line truncates" | ||
optionalText="(Optional)" | ||
> | ||
<fd-wizard-step-indicator>3</fd-wizard-step-indicator> | ||
<fd-wizard-content size="md"> Wizard Content for step 3 </fd-wizard-content> | ||
</li> | ||
</ul> | ||
</fd-wizard-navigation> | ||
<div fd-bar barDesign="footer"> | ||
<div fd-bar-right> | ||
<fd-bar-element> | ||
<button fd-button label="Save" fdType="transparent" [compact]="true"></button> | ||
</fd-bar-element> | ||
<fd-bar-element> | ||
<button fd-button label="Cancel" fdType="transparent" [compact]="true"></button> | ||
</fd-bar-element> | ||
<button fd-button (click)="enterFullscreenExample()">Click to open full screen</button> | ||
|
||
<div cdkScrollable class="docs-wizard-example-overlay" #overlay> | ||
<ng-container *ngIf="fullscreen"> | ||
<div class="docs-wizard-example-overlay-content"> | ||
<div class="docs-wizard-example-button"> | ||
<button fd-button (click)="exitFullscreenExample($event)">Exit Example</button> | ||
</div> | ||
|
||
<!-- The Wizard --> | ||
<fd-wizard [appendToWizard]="false"> | ||
<fd-wizard-navigation> | ||
<ul fd-wizard-progress-bar size="sm"> | ||
<li | ||
fd-wizard-step | ||
[status]="step1status" | ||
(statusChange)="step1status = $event" | ||
label="Step 1: One Line" | ||
> | ||
<fd-wizard-step-indicator glyph="accept"></fd-wizard-step-indicator> | ||
<fd-wizard-content size="md" contentBackground="solid"> | ||
This wizard content has a 'solid' background and padding set with the size input. | ||
<fd-wizard-next-step> | ||
<button fd-button [compact]="true" fdType="emphasized" (click)="goToStep(2)"> | ||
Go to Step 2 | ||
</button> | ||
</fd-wizard-next-step> | ||
</fd-wizard-content> | ||
</li> | ||
<li | ||
fd-wizard-step | ||
[status]="step2status" | ||
(statusChange)="step2status = $event" | ||
label="Step 2: Another Step" | ||
> | ||
<fd-wizard-step-indicator>2</fd-wizard-step-indicator> | ||
<fd-wizard-content size="md"> | ||
Wizard Content for step 2 | ||
<fd-wizard-next-step> | ||
<button fd-button [compact]="true" fdType="emphasized" (click)="goToStep(3)"> | ||
Go to Step 3 | ||
</button> | ||
</fd-wizard-next-step> | ||
</fd-wizard-content> | ||
</li> | ||
<li | ||
fd-wizard-step | ||
[status]="step3status" | ||
(statusChange)="step3status = $event" | ||
label="Step 3: One line truncates" | ||
optionalText="(Optional)" | ||
> | ||
<fd-wizard-step-indicator>3</fd-wizard-step-indicator> | ||
<fd-wizard-content size="md"> Wizard Content for step 3 </fd-wizard-content> | ||
</li> | ||
</ul> | ||
</fd-wizard-navigation> | ||
<div fd-bar barDesign="footer"> | ||
<div fd-bar-right> | ||
<fd-bar-element> | ||
<button fd-button label="Save" fdType="transparent" [compact]="true"></button> | ||
</fd-bar-element> | ||
<fd-bar-element> | ||
<button fd-button label="Cancel" fdType="transparent" [compact]="true"></button> | ||
</fd-bar-element> | ||
</div> | ||
</div> | ||
</fd-wizard> | ||
</div> | ||
</div> | ||
</fd-wizard> | ||
</ng-container> | ||
</div> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use the Dialog for full screen Wizard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it is not meant to be used in a dialog, so I didn't want to give the impression that it is, so I decided to go the same route that the flexible column layout docs are used. The mobile wizard is used in a dialog and I'll use a dialog in that example