fix: expose avatar inputs as part of card header #4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnaAtanasova
approved these changes
Feb 10, 2021
|
Deploy preview for fundamental-ngx ready! Built with commit 744516e |
droshev
force-pushed
the
fix/card-avatar-fix
branch
from
e7fd06e to
af9c60f
Compare
JKMarkowski
reviewed
Feb 11, 2021
Comment on lines
+50
to
+56
| ngAfterContentInit(): void { | ||
| /** Add fd-card__avatar class to fd-avatar */ | ||
| const avatar = this.elementRef().nativeElement.querySelector('fd-avatar'); | ||
| if (avatar) { | ||
| this.renderer.addClass(avatar, 'fd-card__avatar'); | ||
| } | ||
| } |
There was a problem hiding this comment.
What about not having query selector, but @ContentChild? So reference to avatar class is available and s size can be added, when it's missing.
JKMarkowski
approved these changes
Feb 11, 2021
droshev
force-pushed
the
fix/card-avatar-fix
branch
from
af9c60f to
744516e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a brief summary of this pull request.
The avatar in card header doesn't allow setting icons and different sizes
BREAKING CHANGE:
The avatar in card header needs to set size
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md