Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix tab focus, focus styles on popover and avatars, overflow trigger, avatar titles and roles for Avatar Group #5074

Merged
merged 12 commits into from
Jun 5, 2021
Merged

fix(core): fix tab focus, focus styles on popover and avatars, overflow trigger, avatar titles and roles for Avatar Group #5074

merged 12 commits into from
Jun 5, 2021

Conversation

artolshansky
Copy link
Contributor

@artolshansky artolshansky commented Apr 5, 2021 •
edited
Loading

BREAKING CHANGE:

  • Added for noPadding, noHorizontalScroll and noVerticalScroll inputs for AvatarGroupOverflowBodyDirective (fd-avatar-group-overflow-body).
  • Added AvatarGroupFocusableAvatarDirective (fd-avatar-group-focusable-avatar) needed to bind styles for focusable Avatars.
  • Changes in markup

NOTE: in this PR fundamental-styles updated to 0.18.1-rc.23, because of a few issues resolved in styles.

Please provide a link to the associated issue.

Closes: #5071
Closes: #5278
Closes: #5047
Closes: #5285

Please provide a brief summary of this pull request.

  • Group Type tab focusing on the whole Avatar Group and can trigger overflow popover by Enter key
  • focus styles on popover-control
  • aria-labels for avatars
  • total number of team members in case of Group Type

Please check whether the PR fulfills the following requirements

Documentation checklist:

@artolshansky artolshansky added the core Core library specific issues label Apr 5, 2021
@artolshansky artolshansky added this to the Sprint 59 - ariba milestone Apr 5, 2021
@artolshansky artolshansky requested review from DeepakSap14 and a team April 5, 2021 17:03
@artolshansky artolshansky self-assigned this Apr 5, 2021
@netlify
Copy link

netlify bot commented Apr 5, 2021 •
edited
Loading

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 8354979

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60ba5f972506b7000bbac306

😎 Browse the preview: https://deploy-preview-5074--fundamental-ngx.netlify.app

droshev
droshev requested changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olshansky this is not a fix:, since the changes are in the docs

@InnaAtanasova
Copy link
Contributor

Please use more descriptive name for the PR and provide summary in the PR template.

@artolshansky artolshansky changed the title fix: (Core) Avatar Group group type overflow & avatar label docs: (Core) Avatar Group – focus on group type and trigger overflow on Enter key, aria-labels for avatars Apr 6, 2021
droshev
droshev requested changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are touching the component then the PR should not start with docs:

libs/core/src/lib/avatar-group/avatar-group.component.scss Outdated Show resolved Hide resolved
@artolshansky artolshansky requested a review from droshev April 7, 2021 15:58
@artolshansky artolshansky changed the title docs: (Core) Avatar Group – focus on group type and trigger overflow on Enter key, aria-labels for avatars fix: (Core) Avatar Group – focus on group type and trigger overflow on Enter key, aria-labels for avatars Apr 7, 2021
@artolshansky artolshansky mentioned this pull request Apr 7, 2021
Closed
@artolshansky artolshansky force-pushed the fix/avatar-group-overflow branch from 7ced1af to 531d836 Compare April 13, 2021 09:21
@nikvalor nikvalor assigned nikvalor and unassigned nikvalor Apr 28, 2021
@N1XUS N1XUS self-requested a review May 21, 2021 08:37
@artolshansky artolshansky mentioned this pull request May 28, 2021
Closed
@artolshansky artolshansky force-pushed the fix/avatar-group-overflow branch 2 times, most recently from 6fe85f2 to 3af0027 Compare May 31, 2021 10:52
@artolshansky artolshansky added the blocked blocked ticket label Jun 1, 2021
@artolshansky artolshansky force-pushed the fix/avatar-group-overflow branch from 2eb338e to cb8524d Compare June 4, 2021 11:39
@artolshansky artolshansky removed the blocked blocked ticket label Jun 4, 2021
@artolshansky artolshansky changed the title fix: (Core) Avatar Group - fix tab focus, focus styles on popover, overflow trigger, avatar titles and roles fix(core): fix tab focus, focus styles on popover and avatars, overflow trigger, avatar titles and roles for Avatar Group Jun 4, 2021
@puru-hk
Copy link
Contributor

puru-hk commented Jun 4, 2021 •
edited
Loading

Issue 5047 tested it is working as expected.

@artolshansky artolshansky requested review from droshev and removed request for droshev and DeepakSap14 June 4, 2021 12:32
@artolshansky artolshansky merged commit bd3bb03 into main Jun 5, 2021
@artolshansky artolshansky deleted the fix/avatar-group-overflow branch June 5, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@droshev droshev droshev approved these changes

@N1XUS N1XUS N1XUS approved these changes

@Betrozov Betrozov Betrozov approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@Seamoo13 Seamoo13 Seamoo13 approved these changes

Assignees

@artolshansky artolshansky

Labels
core Core library specific issues QA Approved
Projects
None yet
Milestone
No milestone
10 participants
@artolshansky @InnaAtanasova @Betrozov @puru-hk @mikerodonnell89 @droshev @N1XUS @Seamoo13 @manjunathanagaraj @nikvalor