fix: (Platform) i18n remove select, plurals #5109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit eafa9dc |
platon-rov
commented
Apr 13, 2021
libs/platform/src/lib/components/value-help-dialog/models/vhd-strategy.enum.ts
Show resolved
Hide resolved
dimamarksman
suggested changes
Apr 13, 2021
...form/src/lib/components/upload-collection/upload-collection/upload-collection.component.html
Outdated
Show resolved
Hide resolved
...form/src/lib/components/upload-collection/upload-collection/upload-collection.component.html
Outdated
Show resolved
Hide resolved
...form/src/lib/components/upload-collection/upload-collection/upload-collection.component.html
Outdated
Show resolved
Hide resolved
...form/src/lib/components/upload-collection/upload-collection/upload-collection.component.html
Outdated
Show resolved
Hide resolved
platon-rov
force-pushed
the
remove-i18n-select-plurals
branch
from
9bff3e7 to
c25c08e
Compare
dimamarksman
approved these changes
Apr 13, 2021
platon-rov
force-pushed
the
remove-i18n-select-plurals
branch
from
c25c08e to
bdb1832
Compare
InnaAtanasova
approved these changes
Apr 14, 2021
artolshansky
approved these changes
Apr 14, 2021
BREAKING CHANGE: due to needs of SAP's projects was removed support of select and plurals of i18n It followed with changes in i18n markers in the next components: * ApprovalFlow Platform Component * Form Platform Component * Table Platform Component * UploadCollection Platform Component * ValueHelpDialog Platform Component If you're using internationalization with any of these components - you need to re-extract translations (`ng extract-i18n`) and update corresponding strings.
platon-rov
force-pushed
the
remove-i18n-select-plurals
branch
from
bdb1832 to
eafa9dc
Compare
platon-rov
added
ready for qa
DeepakSap14
pushed a commit
that referenced
this pull request
Apr 26, 2021
* fix: (Platform) i18n remove select, plurals BREAKING CHANGE: due to the needs of SAP projects was removed support of select and plurals of i18n It followed with changes in i18n markers in the next components: * ApprovalFlow Platform Component * Form Platform Component * Table Platform Component * UploadCollection Platform Component * ValueHelpDialog Platform Component If you're using internationalization with any of these components - you need to re-extract translations (`ng extract-i18n`) and update corresponding strings. * docs: (Platform) readme update with info about i18n * fix: (Platform) upload collection components improve translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Closes #5098.
Please provide a brief summary of this pull request.
Code of the Platform components refactored to get rid of plural & select features of the i18n. The wiki page about internationalization updated.
As i18n isn't an Angular directive - we're highly limited in next things:
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
Documentation checklist:
README.md