feat: (Platform) approval flow phase 3 #5302

platon-rov · 2021-05-06T07:23:05Z

Please provide a link to the associated issue.

Closes #4993, #4832, #4882, #4884, #4924, #4883.

Please provide a brief summary of this pull request.

Implements features requested, fix component's related bugs.
All requirements here.

Please check whether the PR fulfills the following requirements

the commit message follows the guideline:
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
tests for the changes that have been done
all items on the PR Review Checklist are addressed :
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Run npm run build-pack-library and test in external application

Documentation checklist:

update README.md
Breaking Changes Wiki
Documentation Examples
Stackblitz works for all examples

netlify · 2021-05-06T07:28:31Z

Deploy Preview for fundamental-ngx ready!

Built with commit 2427f8b

https://deploy-preview-5302--fundamental-ngx.netlify.app

KevinOkamoto

I tried the parallel starting nodes scenario:

I thought we decided that there would be a single starting tick, instead of parallel ticks. Then the flow lines would branch from the starting tick to the parallel approvers.

dimamarksman

Great job!
Have a couple of questions

...rc/lib/components/approval-flow/approval-flow-add-node/approval-flow-add-node.component.html

libs/platform/src/lib/components/approval-flow/approval-flow.component.ts

platon-rov · 2021-05-11T15:56:28Z

I tried the parallel starting nodes scenario:

I thought we decided that there would be a single starting tick, instead of parallel ticks. Then the flow lines would branch from the starting tick to the parallel approvers.

Oh, sorry, sure, will add a fix.

manjunathanagaraj · 2021-05-12T15:33:29Z

@platon-rov , I started with 'Empty' scenario. Created parallel nodes(two) at the root level and then couple of serial nodes. After saving, the root node(with two parallel ones) is not properly joined to the next level node.

manjunathanagaraj · 2021-05-12T15:36:47Z

KevinOkamoto

Looks great!

sKudum · 2021-05-17T08:51:00Z

LGTM, except e2e test cases failing. approving it

platon-rov · 2021-05-17T08:57:48Z

@platon-rov , I started with 'Empty' scenario. Created parallel nodes(two) at the root level and then couple of serial nodes. After saving, the root node(with two parallel ones) is not properly joined to the next level node.

I think I should remove the fix as there exist some doubts about that scenario. I sent you an email with the details, in short - we should agree it with design team.

…vements

* Multiple start nodes now supported. * Nested parallel nodes now supported. * Adding nodes to the empty process now supported. * Various bug fixes. * Internationalization extended. Co-authored-by: Sean Moore <[email protected]>

platon-rov marked this pull request as ready for review May 6, 2021 07:29

platon-rov added the platform platform label May 6, 2021

platon-rov requested review from a team May 6, 2021 09:17

This was unlinked from issues May 6, 2021

Accessibility: Approval Flow #5079

Closed

Approval Flow: Accessibility issues #4662

Closed

platon-rov changed the title ~~feat: (Platform) approval flow phase 3~~ [WIP] feat: (Platform) approval flow phase 3 May 7, 2021

platon-rov force-pushed the feat/approval-flow-phase-3 branch 2 times, most recently from 3325fae to e92b4a6 Compare May 11, 2021 11:52

platon-rov changed the title ~~[WIP] feat: (Platform) approval flow phase 3~~ feat: (Platform) approval flow phase 3 May 11, 2021

KevinOkamoto reviewed May 11, 2021

View reviewed changes

dimamarksman reviewed May 11, 2021

View reviewed changes

...rc/lib/components/approval-flow/approval-flow-add-node/approval-flow-add-node.component.html Outdated Show resolved Hide resolved

libs/platform/src/lib/components/approval-flow/approval-flow.component.ts Outdated Show resolved Hide resolved

platon-rov force-pushed the feat/approval-flow-phase-3 branch from e92b4a6 to c854d82 Compare May 13, 2021 10:08

platon-rov requested review from dimamarksman and KevinOkamoto May 13, 2021 12:06

KevinOkamoto approved these changes May 13, 2021

View reviewed changes

sKudum approved these changes May 17, 2021

View reviewed changes

platon-rov and others added 23 commits May 24, 2021 18:53

fix: (Platform) approval flow safety-checking

9094b79

fix: (Platform) approval flow illustrated message fix, code improvements

1eca060

fix: (Platform) approval flow algorithm improvements

2e3023e

fix: (Platform) approval flow error messages refactoring

0b55611

fix: (Platform) approval flow setting only one final node fix

6735e35

fix: (Platform) approval flow multiple root nodes case handling impro…

ce1f1ce

…vements

test: (Platform) approval flow unit test fixes

2d379eb

fix: (Platform) approval flow field visibility fix

f0910cf

fix: (Platform) approval flow code improvements

cbcac24

fix: (Platform) approval flow algorithm improvements, style fixes

3d8bddf

fix: (Platform) approval flow multiple final nodes disallowed

14ec310

test: (Platform) approval flow unit test fix

933b026

test: (Platform) approval flow unit test fix

94e02f3

test: (Platform) approval flow bugfixes, code improvements

5b9dff1

test: (Platform) approval flow node actions fixes

4788b2b

fix: (Platform) approval flow node deletion fixes, code improvements

a003efb

fix: (Platform) approval flow algorithm improvements, fixes, typings

ff3e445

test: (Platform) approval flow style fixes, algorithm improvements

e7b1242

test: (Platform) approval flow algorithm fixes

c4ef8b2

test: (Platform) approval flow adding first node button fix

1c3d472

test: (Platform) approval flow final node restrictions

cf8e5fc

test: (e2e) update approval flow phase 1,2 e2e tests

7288040

fix: (Platform) approval flow edit button toolbar, i18n improvements

93d8c1a

platon-rov force-pushed the feat/approval-flow-phase-3 branch from 4604a3e to 93d8c1a Compare May 24, 2021 15:53

test: (e2e) update approval flow e2e tests

2427f8b

platon-rov merged commit dda7e5b into main May 25, 2021

platon-rov deleted the feat/approval-flow-phase-3 branch May 25, 2021 08:51

kavya-b mentioned this pull request Aug 10, 2021

Test: (Platform) – ApprovalFlowNodeComponent tests failed #4209

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: (Platform) approval flow phase 3 #5302

feat: (Platform) approval flow phase 3 #5302

platon-rov commented May 6, 2021 •

edited

Loading

netlify bot commented May 6, 2021 •

edited

Loading

KevinOkamoto left a comment

dimamarksman left a comment

platon-rov commented May 11, 2021

manjunathanagaraj commented May 12, 2021

manjunathanagaraj commented May 12, 2021

KevinOkamoto left a comment

sKudum commented May 17, 2021

platon-rov commented May 17, 2021

feat: (Platform) approval flow phase 3 #5302

feat: (Platform) approval flow phase 3 #5302

Conversation

platon-rov commented May 6, 2021 • edited Loading

Please provide a link to the associated issue.

Please provide a brief summary of this pull request.

Please check whether the PR fulfills the following requirements

netlify bot commented May 6, 2021 • edited Loading

KevinOkamoto left a comment

Choose a reason for hiding this comment

dimamarksman left a comment

Choose a reason for hiding this comment

platon-rov commented May 11, 2021

manjunathanagaraj commented May 12, 2021

manjunathanagaraj commented May 12, 2021

KevinOkamoto left a comment

Choose a reason for hiding this comment

sKudum commented May 17, 2021

platon-rov commented May 17, 2021

platon-rov commented May 6, 2021 •

edited

Loading

netlify bot commented May 6, 2021 •

edited

Loading