-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): handle invalid date inside date's components #5851
Conversation
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 43b8e1f 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60debf24c1c8060007cedeb7 😎 Browse the preview: https://deploy-preview-5851--fundamental-ngx.netlify.app |
The checkboxes in the PR template should be all checked or marked NA as the |
2eceea5
to
fc37ccc
Compare
fc37ccc
to
43b8e1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The only thing that we are introducing breaking changes
here since now instead of throwing error we are getting an invalid date instance.
Please add corresponding Breaking Changes description in the PR
Co-authored-by: Andrii Suprun <[email protected]>
Please provide a link to the associated issue.
Closes #5059
Please provide a brief summary of this pull request.
This request fixed this issues(read point 3) stackblitz.
What was done:
BREAKING CHANGES:
FdDate class invalid date handling:
You set invalid date params -> You are getting throwing error.
You set invalid date params -> You are getting an invalid date instance.
DateTimePickerComponent invalid date handling:
You type in input invalid date format -> You are getting date instance with current date.
You type in input invalid date format -> You are getting an invalid date instance.
DatePickerComponent invalid date handling:
You type in input invalid date format -> You are getting null
You type in input invalid date format -> You are getting an invalid date instance.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md