fix(docs): fix documentation rtl for dialog #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N1XUS
requested review from
dimamarksman,
InnaAtanasova,
droshev and
mikerodonnell89
N1XUS
added
bug
|
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 16f505a 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60e8840344a1d70008e36ba2 😎 Browse the preview: https://deploy-preview-5924--fundamental-ngx.netlify.app |
InnaAtanasova
approved these changes
Jul 9, 2021
droshev
force-pushed
the
fix/5792-fix-documentation-rtl
branch
from
12c500d to
16f505a
Compare
droshev
approved these changes
Jul 10, 2021
maxym-valor
pushed a commit
to maxym-valor/fundamental-ngx
that referenced
this pull request
Jul 12, 2021
mikerodonnell89
pushed a commit
that referenced
this pull request
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Closes #5792
Please provide a brief summary of this pull request.
Added scoped DialogService to the example container component in order for DialogService to have the same RtlService as the component.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md