feat(core): dialog auto labeling #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platon-rov
force-pushed
the
feat/core/dialog-auto-label
branch
from
1d20224 to
9bea6e8
Compare
platon-rov
added
accessibility
|
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 20e661f 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60fadca950be7100089e381e 😎 Browse the preview: https://deploy-preview-6053--fundamental-ngx.netlify.app |
kavya-b
reviewed
Jul 21, 2021
apps/docs/src/app/core/component-docs/dialog/dialog-docs.component.html
Outdated
Show resolved
Hide resolved
kavya-b
reviewed
Jul 22, 2021
|
On opening the dialog, the focus doesn't go anywhere in the dialog, but in most other examples focus goes to the button; is this expected? |
platon-rov
force-pushed
the
feat/core/dialog-auto-label
branch
from
365694f to
33cd2a6
Compare
It's expected, but to have consistent examples I've added an initial focus directive to the buttons. |
platon-rov
force-pushed
the
feat/core/dialog-auto-label
branch
from
5793372 to
20e661f
Compare
Smiranin
approved these changes
Jul 23, 2021
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
artolshansky
approved these changes
Jul 26, 2021
dimamarksman
approved these changes
Jul 26, 2021
maxym-valor
pushed a commit
to maxym-valor/fundamental-ngx
that referenced
this pull request
Aug 2, 2021
…tr.name in radio button (SAP#6056) chore(release): version 0.31.0-rc.151 build 18851 [ci skip] feat(core): dialog auto labelling (SAP#6053) chore(release): version 0.31.0-rc.152 build 18855 [ci skip] fix(platform): grouping & frozen columns table layout fix (SAP#6043) test(e2e): add e2e tests for date-picker core test(e2e): skip failed scenarios for prod mode (SAP#6110) * test(e2e): update url and visual regression * test(e2e): minor changes * test(e2e): minor changes 2 * test(e2e): skip failed scenarios * test(e2e): skip failed scenarios chore(release): version 0.31.0-rc.153 build 18909 [ci skip] fix(platform): combobox in mobile mode (SAP#6115) chore(release): version 0.31.0-rc.154 build 18923 [ci skip] fix(core): fix extra onChange event in the TimePicker component (SAP#6079) * fix(core): fix extra onChange event * test(e2e): update e2e tests Co-authored-by: nikvalor <[email protected]> chore(release): version 0.31.0-rc.155 build 18928 [ci skip] feat(core): moment date time adapter implementation (SAP#6000) * feat(core): moment date time adapter implementation * feat(core): inclusive language fix * feat(core): replace unused variables * feat(core): moment date time adapter change request implementation * feat(core): moment date time adapter change request implementation * feat(core): moment date time adapter change request implementation * feat(core): moment date time adapter change request implementation * feat(core): moment date time adapter change request implementation * feat(core): add moment-adapter api doc * feat(core): moment-adapter fix publish commands Co-authored-by: dimamarksman <[email protected]> chore(release): version 0.31.0-rc.156 build 18929 [ci skip] docs(platform): add ariba labels to those component doc pages (SAP#6051) * docs(platform): add ariba labels to those component doc pages * docs: update the info labels with the components chore(release): version 0.31.0-rc.157 build 18932 [ci skip] fix(platform): add attribute option into combobox (SAP#5772) * fix(platform): add attribute option into combobox * fix(platform): delete interaction states * fix(platform): delete styles into combobox component * test(e2e): update visual regression * fix(platform): remove tabindex * test(e2e): update visual regression Co-authored-by: nikvalor <[email protected]> chore(release): version 0.31.0-rc.158 build 18935 [ci skip] fix(platform): fix search component keyboard accessibility and screen reader issues (SAP#5673) * fix(platform): esc button close and taborder * fix(platform): select list item on tab * fix(platform): menu trigger on spacebar * fix(platform): menu item select on spacebar * fix(platform): search suggestion announcement fixed with aria-live * test(platform): fixed failing test case for timer * fix(platform): using Keyutil and custom message * fix(platform): reference comment added * test(platform): e2e test fix * fix(platform): use liveAnnouncer from cdk * fix(platform): change message variable to private * fix(platform): use keyutil and code formatting * fix(platform): remove role search, correct count for suggestion * fix(platform): travis fix and review comments chore(release): version 0.31.0-rc.159 build 18954 [ci skip] fix(core): remove css from fixed-card-layout component, use correct class names (SAP#6009) * fix(core): remove css from fixed-card-layout, use correct class names * fix(core): broken travis tests fix * fix(core): broken travis tests fix * fix(core): add cdk-drag-disabled class to change cursor to default fix(core,platform): remove css from list component, use correct class names (SAP#6010) BREAKING CHANGE: Removed [noSeperator] property in list component as it was not necessary, as we have [noBorder] property which has the same functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Closes #6052.
Please provide a brief summary of this pull request.
Dialog auto labeling feature using the directive.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md