Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core,platform): add ability to show summary step #6244

Merged
merged 7 commits into from
Aug 13, 2021

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Aug 5, 2021

Please provide a link to the associated issue.

Closes #6132

Please provide a brief summary of this pull request.

Added ability to specify if summary step should be visible in progress bar for core wizard and platform wizard generator.

Please check whether the PR fulfills the following requirements

Documentation checklist:

@N1XUS N1XUS requested review from a team August 5, 2021 12:46
@N1XUS N1XUS self-assigned this Aug 5, 2021
@N1XUS N1XUS added the bug Something isn't working label Aug 5, 2021
@N1XUS N1XUS added this to the Sprint 67 - Seville milestone Aug 5, 2021
@netlify
Copy link

netlify bot commented Aug 5, 2021

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 51f1274

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/6116a149dc446d00074128c5

😎 Browse the preview: https://deploy-preview-6244--fundamental-ngx.netlify.app

@github-actions
Copy link

github-actions bot commented Aug 9, 2021

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Aug 9, 2021
@InnaAtanasova
Copy link
Contributor

prob not related to your PR, but the branching example is not working because the dropdown to select the type is not working:
Screen Shot 2021-08-09 at 2 50 21 PM

@github-actions github-actions bot removed the stale label Aug 10, 2021
@platon-rov
Copy link
Contributor

Not sure if this should be included in current PR but the animation for switching steps for the mobile mode too fast, it blinks.

@droshev
Copy link
Contributor

droshev commented Aug 10, 2021

@N1XUS can you rebase as maybe the e2e were fixed?

@mikerodonnell89
Copy link
Member

mikerodonnell89 commented Aug 10, 2021

Not sure if this should be included in current PR but the animation for switching steps for the mobile mode too fast, it blinks.

@platon-rov Looks like this is happening to the progress bar but good catch. Should be considered a separate issue. New issue here: #6294

@mikerodonnell89
Copy link
Member

mikerodonnell89 commented Aug 10, 2021

prob not related to your PR, but the branching example is not working because the dropdown to select the type is not working:
Screen Shot 2021-08-09 at 2 50 21 PM

Can confirm not unique to this pr @InnaAtanasova new issue here #6295

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N1XUS I see that the summary is listed as the last step for wizard in dialog on the platform generator but not on core

@droshev droshev requested review from a team August 11, 2021 03:13
@N1XUS
Copy link
Contributor Author

N1XUS commented Aug 11, 2021

@N1XUS I see that the summary is listed as the last step for wizard in dialog on the platform generator but not on core

@mikerodonnell89 please check this link: https://deploy-preview-6244--fundamental-ngx.netlify.app/#/core/wizard#visible-summary

@mikerodonnell89
Copy link
Member

@N1XUS I see that the summary is listed as the last step for wizard in dialog on the platform generator but not on core

@mikerodonnell89 please check this link: https://deploy-preview-6244--fundamental-ngx.netlify.app/#/core/wizard#visible-summary

@N1XUS after discussing with @droshev we can confirm that this should be default behavior - so we should also be seeing it in this example: https://deploy-preview-6244--fundamental-ngx.netlify.app/#/core/wizard#dialog

@@ -76,6 +76,9 @@ export class WizardStepComponent implements OnChanges, AfterViewInit, OnDestroy
@Input()
isSummary = false;

@Input()
displaySummary = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this needs to be an input. It can be a hidden property of the wizard-step component, and the wizard can iterate through ContentChildren to set this property when [displaySummaryStep]="true" on the wizard component.

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two small things, see above comments

@N1XUS N1XUS requested a review from mikerodonnell89 August 13, 2021 13:12
@lgtm-com
Copy link

lgtm-com bot commented Aug 13, 2021

This pull request introduces 1 alert when merging 80e4b05 into 17a6cb5 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@droshev droshev force-pushed the fix/6132-visible-summary-step branch from bfcff16 to 51f1274 Compare August 13, 2021 16:43
@droshev droshev merged commit 9042052 into main Aug 13, 2021
@droshev droshev deleted the fix/6132-visible-summary-step branch August 13, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wizard in a dialog summary page should be shown as the last step
5 participants