-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core,platform): add ability to show summary step #6244
Conversation
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 51f1274 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/6116a149dc446d00074128c5 😎 Browse the preview: https://deploy-preview-6244--fundamental-ngx.netlify.app |
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
Not sure if this should be included in current PR but the animation for switching steps for the mobile mode too fast, it blinks. |
@N1XUS can you rebase as maybe the e2e were fixed? |
@platon-rov Looks like this is happening to the progress bar but good catch. Should be considered a separate issue. New issue here: #6294 |
Can confirm not unique to this pr @InnaAtanasova new issue here #6295 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N1XUS I see that the summary is listed as the last step for wizard in dialog on the platform generator but not on core
@mikerodonnell89 please check this link: https://deploy-preview-6244--fundamental-ngx.netlify.app/#/core/wizard#visible-summary |
@N1XUS after discussing with @droshev we can confirm that this should be default behavior - so we should also be seeing it in this example: https://deploy-preview-6244--fundamental-ngx.netlify.app/#/core/wizard#dialog |
@@ -76,6 +76,9 @@ export class WizardStepComponent implements OnChanges, AfterViewInit, OnDestroy | |||
@Input() | |||
isSummary = false; | |||
|
|||
@Input() | |||
displaySummary = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this needs to be an input. It can be a hidden property of the wizard-step component, and the wizard can iterate through ContentChildren to set this property when [displaySummaryStep]="true"
on the wizard component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two small things, see above comments
This pull request introduces 1 alert when merging 80e4b05 into 17a6cb5 - view on LGTM.com new alerts:
|
bfcff16
to
51f1274
Compare
Please provide a link to the associated issue.
Closes #6132
Please provide a brief summary of this pull request.
Added ability to specify if summary step should be visible in progress bar for core wizard and platform wizard generator.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md