-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): split platform into libraries #6390
Conversation
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 0bd64e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/6130d9f69ec5f30009cf817f 😎 Browse the preview: https://deploy-preview-6390--fundamental-ngx.netlify.app/assets/typedoc/platform/classes/tablecomponent |
69c7564
to
2b73a8f
Compare
This pull request fixes 32 alerts when merging 2b73a8f into 52d8f88 - view on LGTM.com fixed alerts:
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
This pull request fixes 32 alerts when merging f919e73 into fe8a11f - view on LGTM.com fixed alerts:
|
Question: Denis from my team made the split in a way that the old way is still supported. Basically both options are currently possible. Is it the case with the Platform split? |
Hi @InnaAtanasova |
This pull request fixes 32 alerts when merging 15998f2 into 1db9de9 - view on LGTM.com fixed alerts:
|
@Betrozov I see some failing unit tests in core lib. Does it has something to do with the PR? |
apps/docs/src/app/platform/component-docs/platform-button/platform-button.module.ts
Outdated
Show resolved
Hide resolved
15998f2
to
0bd64e7
Compare
This pull request fixes 30 alerts when merging 0bd64e7 into 3b1b52c - view on LGTM.com fixed alerts:
|
Travis fixed |
Please provide a link to the associated issue.
Closes: #5912
Please provide a brief summary of this pull request.
Split platform library into multiple sub-packages.
nx test platform-[module-name]
commandPlease check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md