Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): split platform into libraries #6390

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

artolshansky
Copy link
Contributor

Please provide a link to the associated issue.

Closes: #5912

Please provide a brief summary of this pull request.

Split platform library into multiple sub-packages.

  • Libraries are built with nx instead of ng;
  • All main platform modules are now built as separate sub-packages;
  • Recommended way of importing files from the platform library now is following:
import { PlatformButtonModule } from '@fundamental-ngx/platform/button';
  • Structure of fundamental-ngx/platform was refactored to allow splitting it into separate sub-packages;
  • Platform documentation has been updated with the appropriate import paths;
  • TSPath has been updated to reflect all separate submodules paths;
  • root tsconfig.json has been renamed to tsconfig.base.json;
  • folders from utils has been moved to a separate shared sub-package;
  • each library contains own tsconfig.json file with strict mode disabled, and can be enabled on per-package basis;
  • Now it is possible to launch module-specific unit tests by using nx test platform-[module-name] command

Please check whether the PR fulfills the following requirements

Documentation checklist:

@artolshansky artolshansky added the platform platform label Aug 26, 2021
@artolshansky artolshansky requested review from a team August 26, 2021 13:33
@artolshansky artolshansky self-assigned this Aug 26, 2021
@netlify
Copy link

netlify bot commented Aug 26, 2021

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 0bd64e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/6130d9f69ec5f30009cf817f

😎 Browse the preview: https://deploy-preview-6390--fundamental-ngx.netlify.app/assets/typedoc/platform/classes/tablecomponent

@artolshansky artolshansky force-pushed the feat/split-platform-to-submodules branch 4 times, most recently from 69c7564 to 2b73a8f Compare August 27, 2021 13:06
@SAP SAP deleted a comment from lgtm-com bot Aug 27, 2021
@SAP SAP deleted a comment from lgtm-com bot Aug 27, 2021
@SAP SAP deleted a comment from lgtm-com bot Aug 27, 2021
@SAP SAP deleted a comment from lgtm-com bot Aug 27, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 27, 2021

This pull request fixes 32 alerts when merging 2b73a8f into 52d8f88 - view on LGTM.com

fixed alerts:

  • 32 for Unused variable, import, function or class

@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Aug 30, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 30, 2021

This pull request fixes 32 alerts when merging f919e73 into fe8a11f - view on LGTM.com

fixed alerts:

  • 32 for Unused variable, import, function or class

@InnaAtanasova
Copy link
Contributor

Question: Denis from my team made the split in a way that the old way is still supported. Basically both options are currently possible. Is it the case with the Platform split?

@github-actions github-actions bot removed the stale label Aug 31, 2021
@Betrozov Betrozov self-assigned this Aug 31, 2021
@Betrozov
Copy link
Contributor

Question: Denis from my team made the split in a way that the old way is still supported. Basically both options are currently possible. Is it the case with the Platform split?

Hi @InnaAtanasova
Yes, the old way is still supported

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2021

This pull request fixes 32 alerts when merging 15998f2 into 1db9de9 - view on LGTM.com

fixed alerts:

  • 32 for Unused variable, import, function or class

@N1XUS
Copy link
Contributor

N1XUS commented Sep 1, 2021

@Betrozov I see some failing unit tests in core lib. Does it has something to do with the PR?

@Betrozov Betrozov force-pushed the feat/split-platform-to-submodules branch from 15998f2 to 0bd64e7 Compare September 2, 2021 14:04
@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2021

This pull request fixes 30 alerts when merging 0bd64e7 into 3b1b52c - view on LGTM.com

fixed alerts:

  • 30 for Unused variable, import, function or class

@Betrozov
Copy link
Contributor

Betrozov commented Sep 2, 2021

@Betrozov I see some failing unit tests in core lib. Does it has something to do with the PR?

Travis fixed

@Betrozov Betrozov added the ready for qa Testing should be started for the PR label Sep 2, 2021
@Seamoo13 Seamoo13 added Testing (QA) QA testing in progress QA Approved and removed ready for qa Testing should be started for the PR Testing (QA) QA testing in progress labels Sep 3, 2021
@droshev droshev merged commit b9a3951 into main Sep 3, 2021
@droshev droshev deleted the feat/split-platform-to-submodules branch September 3, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Platform into sub-packages
8 participants