fix(platform): dynamic page facets and title content, refactoring #8527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Visit the preview URL for this PR (updated for commit f0fa3e8): https://fundamental-ngx-gh--pr8527-pr-fix-platform-dyna-cnlpn7tw.web.app (expires Thu, 18 Aug 2022 11:32:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
InnaAtanasova
approved these changes
Aug 10, 2022
platon-rov
force-pushed
the
pr/fix/platform-dynamic-page-facets-and-title-content
branch
from
dbb1426 to
6992c97
Compare
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
BREAKING CHANGE: * fdp-dynamic-page-title-host component removed as not used
platon-rov
force-pushed
the
pr/fix/platform-dynamic-page-facets-and-title-content
branch
from
6992c97 to
48934e9
Compare
platon-rov
deleted the
pr/fix/platform-dynamic-page-facets-and-title-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Refers to DXP.
Description
Platform Dynamic Page
fdp-dynamic-page-title-hostcomponent removing (not used)Screenshots
Before:
After:
Please check whether the PR fulfills the following requirements
PR Quality