-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): shellbar improvements #9287
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ca18903
to
4ab0f4e
Compare
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
libs/core/src/lib/shellbar/shellbar-actions-mobile/shellbar-actions-mobile.component.ts
Show resolved
Hide resolved
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Visit the preview URL for this PR (updated for commit 5d8cbe5): https://fundamental-ngx-gh--pr9287-feat-shellbar-enhanc-8zp7qmsw.web.app (expires Sat, 04 Feb 2023 13:42:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool!
Changes should be marked as breaking in the commit message.
libs/core/src/lib/shellbar/shellbar-actions-mobile/shellbar-actions-mobile.component.ts
Show resolved
Hide resolved
libs/core/src/lib/shellbar/shellbar-actions/shellbar-actions.component.html
Outdated
Show resolved
Hide resolved
libs/core/src/lib/shellbar/shellbar-actions/shellbar-actions.component.html
Outdated
Show resolved
Hide resolved
@platon-rov thank you! Your comments are being addressed, please take a look. |
9e8971a
to
38cf5ca
Compare
38cf5ca
to
dd0c0f2
Compare
dd0c0f2
to
715b6bb
Compare
Related Issue(s)
closes #7966
Description
Screenshots
Before:
After:
Please check whether the PR fulfills the following requirements
During Implementation
PR Quality
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
README.md