Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): shellbar improvements #9287

Merged
merged 6 commits into from
Feb 1, 2023
Merged

feat(core): shellbar improvements #9287

merged 6 commits into from
Feb 1, 2023

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Jan 27, 2023

Related Issue(s)

closes #7966

Description

  • Applied new styling of the shellbar;
  • added ability to indirectly use platform search inside core shellbar;
  • added additional styling for the search field inside shellbar;
  • added ability to automatically detect fitting size of the shellbar if none was provided;
  • added ability to move the search field inside shellbar between root of the shellbar and shellbar actions;
  • added missing translations for shellbar;
  • changed some content children to use lightweight tokens instead of component reference;

Screenshots

Before:

image

After:

image

image

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@N1XUS N1XUS added enhancement New feature or request core Core library specific issues labels Jan 27, 2023
@N1XUS N1XUS added this to the Sprint 105 milestone Jan 27, 2023
@N1XUS N1XUS requested a review from a team January 27, 2023 07:28
@N1XUS N1XUS self-assigned this Jan 27, 2023
@netlify
Copy link

netlify bot commented Jan 27, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 0f29028
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/63d37d217f408c0009ef3ac1
😎 Deploy Preview https://deploy-preview-9287--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@N1XUS N1XUS force-pushed the feat/shellbar-enhancements branch from ca18903 to 4ab0f4e Compare January 27, 2023 07:40
@netlify
Copy link

netlify bot commented Jan 27, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit ca18903
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/63d37f3d51487200086fb61c
😎 Deploy Preview https://deploy-preview-9287--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 27, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 5d8cbe5
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/63da69facb1ff900092c9367
😎 Deploy Preview https://deploy-preview-9287--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jan 27, 2023

Visit the preview URL for this PR (updated for commit 5d8cbe5):

https://fundamental-ngx-gh--pr9287-feat-shellbar-enhanc-8zp7qmsw.web.app

(expires Sat, 04 Feb 2023 13:42:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Copy link
Contributor

@platon-rov platon-rov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

Changes should be marked as breaking in the commit message.

@N1XUS N1XUS requested a review from platon-rov January 27, 2023 13:14
@N1XUS
Copy link
Contributor Author

N1XUS commented Jan 27, 2023

@platon-rov thank you! Your comments are being addressed, please take a look.

@N1XUS N1XUS force-pushed the feat/shellbar-enhancements branch 4 times, most recently from 9e8971a to 38cf5ca Compare January 30, 2023 15:28
@N1XUS N1XUS force-pushed the feat/shellbar-enhancements branch from 38cf5ca to dd0c0f2 Compare January 31, 2023 15:21
@N1XUS N1XUS force-pushed the feat/shellbar-enhancements branch from dd0c0f2 to 715b6bb Compare February 1, 2023 07:31
@N1XUS N1XUS merged commit 7e4b09e into main Feb 1, 2023
@N1XUS N1XUS deleted the feat/shellbar-enhancements branch February 1, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shellbar enhancements
2 participants