Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): message toast custom positions #9810

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented May 9, 2023

Related Issue(s)

closes #9758

Description

  • Refactored old Message Toast component to use CDK Overlay;
  • Moved @fundamental-ngx/fn/cdk parts to @fundamental-ngx/cdk package;
  • @fundamental-ngx/fn/cdk is no longer available;
  • Message Toast now can be animated;
  • Message Toast now can accept custom position based on CDK Overlay Position strategy.

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@N1XUS N1XUS added enhancement New feature or request code refactoring core Core library specific issues labels May 9, 2023
@N1XUS N1XUS added this to the Sprint 112 milestone May 9, 2023
@N1XUS N1XUS requested a review from a team May 9, 2023 07:25
@N1XUS N1XUS self-assigned this May 9, 2023
@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 809f43f
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/645b4b42c9bb07000873adf2
😎 Deploy Preview https://deploy-preview-9810--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@N1XUS N1XUS force-pushed the feat/9758-toast-overlay branch from 26c72f6 to 29f2db4 Compare May 9, 2023 08:40
@github-actions
Copy link

github-actions bot commented May 9, 2023

Visit the preview URL for this PR (updated for commit 809f43f):

https://fundamental-ngx-gh--pr9810-feat-9758-toast-over-o4ptwl8w.web.app

(expires Sat, 13 May 2023 08:00:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@N1XUS N1XUS force-pushed the feat/9758-toast-overlay branch from 29f2db4 to 848363c Compare May 9, 2023 13:09
@N1XUS N1XUS force-pushed the feat/9758-toast-overlay branch from 848363c to 93cdacf Compare May 9, 2023 20:29
@N1XUS N1XUS force-pushed the feat/9758-toast-overlay branch from 93cdacf to 809f43f Compare May 10, 2023 07:44
@N1XUS N1XUS merged commit 5ab4981 into main May 10, 2023
@N1XUS N1XUS deleted the feat/9758-toast-overlay branch May 10, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code refactoring core Core library specific issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message Toast API enhancement
2 participants