Custom fs option #17
Merged
Custom fs option #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise less would still use the native "fs" module.
When using a custom "fs", the lessInputPath might not be as expected when trying to get the corresponding sap/ui/core path. Therefore the "library.name" option will be used to resolve the core namespace.
Add test for a simple interface and check that it is actually called.
|
Added docs / tests |
RandomByte
reviewed
Dec 12, 2017
lib/index.js
Outdated
| var fnFileHandler; | ||
| if (options.rootPaths && options.rootPaths.length > 0) { | ||
| if (options.rootPaths && options.rootPaths.length > 0 || that.customFs) { |
There was a problem hiding this comment.
Maybe add brackets to make the condition easier to read
|
|
svbender
reviewed
Dec 13, 2017
README.md
Outdated
| ##### fs | ||
| Type: [Node.js `fs` interface](https://nodejs.org/api/fs.html) | ||
|
|
||
| By default, all file system accees is done via the standard Node.js file system ("fs"). With this option an alternative file system can be passed and will be used for all file system operations. |
| if (rootPaths && rootPaths.length > 0) { | ||
| return statFiles( | ||
| rootPaths.map(function(rootPath) { | ||
| return path.join(rootPath, filePath); |
There was a problem hiding this comment.
Please use path.posix.join
svbender
approved these changes
Dec 13, 2017
|
Also fine from my side. I will resolve the conflicts so that we can merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.