[INTERNAL] ui5-test-runner: Use --start option and remove unused dependency #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --start option is new and allows us to have one less dependency. Also, --port 8081 is only useful for some minimal test monitoring and hence more confusing than of actual use, as mentioned by Arnaud at: SAP-samples/ui5-typescript-helloworld#31 (comment)
akudev
requested review from
flovogt and
matz3
and removed request for
flovogt
flovogt
approved these changes
Feb 6, 2025
flovogt
changed the title
flovogt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --start option is new and allows us to have one less dependency. Also, --port 8081 is only useful for some minimal test monitoring and hence more confusing than of actual use, as mentioned by Arnaud at: SAP-samples/ui5-typescript-helloworld#31 (comment)