Use ISO-8859-1 encoding for i18n files #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As expected by the UI5 Tooling
|
Encoding conversion not required based on new concept: SAP/ui5-tooling#168 |
|
@RandomByte or do we want to use normal UTF-8 then? |
|
Well, UTF8 would be nice but bloats the ui5.yaml a bit. I don't like the current content of the _de file (containing unicode escapes) since they are hard to read. I think I'm in favor of using normal UTF-8, without escapes and the additional ui5.yaml configuration. |
|
Follow up: #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As expected by the UI5 Tooling