Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright 1.41 #192

Merged
3,326 commits merged into from
Jan 18, 2024
Merged

Playwright 1.41 #192

3,326 commits merged into from
Jan 18, 2024

Conversation

tmbrbr
Copy link
Contributor

@tmbrbr tmbrbr commented Jan 18, 2024

Updating to browser patches compatible with playwright 1.41

Closes #190

updatebot-ci and others added 30 commits September 25, 2023 12:42
…esktop-theme-reviewers, a=dsmith

The `menubar` has bright text and thus we use `color-scheme: dark` on it
to get the right colors.

But popups should generally be able to render on the preferred color
scheme.

Differential Revision: https://phabricator.services.mozilla.com/D189025
…dsmith

This is purely a cleanup of some unintentionally left over logging
messages from Part 1.

Differential Revision: https://phabricator.services.mozilla.com/D189143
…s. r=dao,desktop-theme-reviewers, a=dsmith

Turns out macOS relies on the background being set in the toolbox rather
than :root because we slide the toolbox down entirely when the menubar
shows up in full-screen.

Since this is also the set up we have for lightweight themes and Linux,
and we can change Windows to do the same now that Aero is not a thing
anymore, clean-up the code and move all the toolbox background code to a
shared place.

In the future if we want to do something like Mica / Aero on Windows
again, we could do this trivially by setting --toolbox-non-lwt-bgcolor:
transparent or so on the relevant platform's file.

I can write a simpler patch for beta if needed.

Differential Revision: https://phabricator.services.mozilla.com/D189055
…survey r=omc-reviewers,desktop-theme-reviewers,dao,aminomancer, a=dsmith

Differential Revision: https://phabricator.services.mozilla.com/D188764
…up to Suggest pings. r=nanj, a=dsmith

This adds two new fields to the Suggest PingCentre and Glean pings:

* `suggested_index` -
  An integer value that is the intended index of the suggestion
  being interacted with. If `suggested_index_relative_to_group` is true, the
  index is relative to the "Firefox Suggest" group; otherwise the index is
  relative to the entire list of suggestions. Non-negative values (starting
  at 0) are relative to the start/top of the group/list; negative values are
  relative to the end/bottom of the group/list.
* `suggested_index_relative_to_group` -
  Whether `suggested_index` is relative to the "Firefox Suggest" group. If
  false, it is relative to the entire list of suggestions.

In the Glean ping, `suggested_index` is stringified because there's no integer
metric type that can take negative numbers.

These two values reflect how the implementation works and will let us record any
indexes we want to experiment with. Suggestions are usually shown at the bottom
of the Firefox Suggest group, and in that case these values will be:

```
suggested_index = -1
suggested_index_relative_to_group = true
```

If we want to show suggestions at the top of the Firefox Suggest group instead
of the bottom, the values will be:

```
suggested_index = 0
suggested_index_relative_to_group = true
```

Differential Revision: https://phabricator.services.mozilla.com/D189035
….css. r=dao,desktop-theme-reviewers, a=dsmith

When loaded from there, the triggering principal is the system principal
and we go through:

  https://searchfox.org/mozilla-central/rev/95ec620fda8ad6e4096cac1f1a9db8653669b31d/dom/security/nsContentSecurityManager.cpp#1650-1657

Otherwise we fail the check because the triggering principal is a
ContentPrincipal with "chrome://browser/skin/browser.css" as the URI.

That seems a bit unexpected and deserves some looking into, but let's
unbreak themes in the meantime.

Differential Revision: https://phabricator.services.mozilla.com/D189209
…htweight themes. r=dao,desktop-theme-reviewers, a=dsmith

Much like with link colors. This restores the behavior on Linux with a
custom theme.

Differential Revision: https://phabricator.services.mozilla.com/D189190
…nto gray instead of a red color r=mtigley, a=dsmith

Differential Revision: https://phabricator.services.mozilla.com/D187563
…to allow builds to modify it. r=extension-reviewers,robwu, a=dsmith

Differential Revision: https://phabricator.services.mozilla.com/D188571
…etting the TRR mode when set via about:config r=owlish, a=dsmith

Differential Revision: https://phabricator.services.mozilla.com/D189106
…e, a=dsmith

* Add events to new context menu items and open tab clicks

Differential Revision: https://phabricator.services.mozilla.com/D188962
de -> d38a5a358798688665e465f8b43025934756d560
fi -> 06677d871ef9a54fd567c205c5ccaa40340fdc58
gn -> ce220c2f616ee2d82dde3ee3f7fb6418fe712639
it -> e9458f6c555bc2d1860693005161dfd2664d682b
ka -> c18408d748ecc6e1418f20a3e7f5cfce4a7ad236
nb-NO -> 38b554fec939e4b881412f0e6762326470cc100e
pa-IN -> d54139648a7f8bb6059aca02e0541c6f202cccdd
pt-BR -> da937f87feba2732af39be1eaa0d52c50c371e61
si -> b27c3460e031af989eb49930279bb52e5e91fb74
tr -> ed9829c084ddaa3ad6aa5eecd4942803dcdc79a5
…X_119_0b2_BUILD1 a=release CLOSED TREE DONTBUILD
…TION_119_0b2_BUILD1 a=release CLOSED TREE DONTBUILD
…X_119_0b2_RELEASE a=release CLOSED TREE DONTBUILD
Mozilla Releng Treescript and others added 28 commits October 13, 2023 09:14
el -> 44db459be1a2651af771a93336b57a83feb3c6e4
fi -> b57082c23fed4221653bdbb90239d5d6fce0c09b
fr -> 2c2b6835e611de336c22e3887e7d5f1a9d3bf28e
gn -> becb3e94f26e57da01a74f6555447e72855a3e78
it -> a70761250de8ab91fff40be16c613a617711adf4
ka -> a1fa361d1b5dd5f911907fed691b18e0710e034a
nn-NO -> 197abc4fac9566518e45a7c3ed42603ec82b9928
oc -> 69372c47468b9b4217c1824034fee43de6394ce2
pa-IN -> b271804846e323fc7c5ea4689158f58f0a03ad68
tg -> 5424b2f596b3f321e3d50b7a26ca5a8a421f5b35
zh-CN -> 853659d756844d448d6da1b57ec8e2055bae96d1
…TION_119_0b9_BUILD1 a=release CLOSED TREE DONTBUILD
…X_119_0b9_BUILD1 a=release CLOSED TREE DONTBUILD
…TION_119_0b9_RELEASE a=release CLOSED TREE DONTBUILD
…X_119_0b9_RELEASE a=release CLOSED TREE DONTBUILD
…r=nalexander, a=dmeehan

The previous commits to shared.nsh resulted in auto-pinning only occurring in Windows 11 builds that weren't build number 22621 or higher, but a lot of users on Windows 11 are on 22621 already and the build number to pay attention to, when MS introduced the user confirmation for pinning popup, is in Windows 11, 22621, UBR 2361.
This commit checks for the UBR number too.

Differential Revision: https://phabricator.services.mozilla.com/D190859
da -> 801762d1e865492507d5eb694e7e2ba2030aa88e
el -> a85f46c10a445226a79a5262ca75c31ddd08274c
fur -> 7fd6c54d01e9ac336ce6c09dc943d31792523261
gn -> 0fa7f55ed6790d99b8af40e2dfafd02a4f422991
hy-AM -> 6df5669dafae4458baa0da068849d1226d77786f
it -> a52767deb2a4d710544be2c3735502cda3239cf1
rm -> d73e3a68664a075321a9bd552ea87e993ce8903d
sl -> 3404d57e87248cde536b046ecc90e8d660fbe932
th -> bd39c196d7d9592c71ab16751bc8b6c79856082c
uk -> 53bcc62aa169521f752cffea02f830982520b42d
ar -> 0714cafed8c68356828a49b4af2644a49df873dc
cs -> f3d8bfbe8661fb037c943e58360b74cc9e3dbc54
de -> 4a3d98c7e8b76a27e4a75e191676eb050fc4a61f
eo -> 80ea02defe7194c108b515cfefb31d7e44e497f1
fi -> 5a1cec27635e33e33d48aa02bd55a745d06028a6
fr -> a2ff61a05d98f6ac590af31e20b9584f3fc1ce59
ka -> a258fa14d0f93d218824464b166fe9517f729bef
oc -> 80ec07351221caaac38f39732482fa83efd59417
sl -> c2c0fe424d946150992d5f040c2338908535aae1
sq -> 8dd1619a504146ed454cec7e9c9ffb0113363df6
be -> 3a289c68aa39cf5f3ba87166091889591f61ca45
ca -> 98ac6d426d80c134e560c731ae3b77f849c9ce50
eo -> cae536ce04ee27467745a35243d47d323c0109cf
es-ES -> 0c61d58a873eb41ad722d87dcdbe9c2ab60f3da0
fi -> d23b07cffb8d00c6e9e109ca62c3dfc5277f8b58
fur -> 2e64aa1b48b3d5ced46a08196753aa90fd16ab18
hu -> 032737844c01ed686e53690a0cee56df86ad0d67
ia -> c9aae1b862b4b239c56cb12fdbc885da88fa25b0
it -> 382ca60beb3d4245a903913cd35945792af5a3ce
ko -> 8fc8caabb6ddfab814dbfd5274935eb0371cb465
pl -> 531c26750580874f02ca01a969829a09a21244c0
rm -> b466979a1186413876527dad522b641b430bdb56
sl -> c87d658546760a791021f249a7a79a58c18df8c9
sq -> 2ccb8ba833fa0ccab1c1850d7f7e26e3eb77c702
tr -> f3eebbde945898b381a9ef7d3aeb503303fe136a
uk -> f56a49db6c1cd1dc8f6b3f5cab72eef441761952
zh-TW -> 3faad915bdc849683ac19341c5143ed3c27bb2ab
…X_RELEASE_119_BASE a=release DONTBUILD CLOSED TREE
…9262be540d a43e95756b87a0d585d9afcd1d45b3cecb8b9c47| CLOSED TREE DONTBUILD a=release
…X_RELEASE_118_END a=release DONTBUILD CLOSED TREE
…X_119_0_BUILD1 a=release CLOSED TREE DONTBUILD
Copy link

cla-assistant bot commented Jan 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 15 committers have signed the CLA.

✅ tmbrbr
❌ Max Christian Pohle
❌ padenot
❌ sefeng211
❌ bomsy
❌ saschanaz
❌ mhughes-mozilla
❌ PrototypeNM1
❌ bhearsum
❌ mathewhodson
❌ jcsteh
❌ makotokato
❌ jld
❌ gabrielesvelto
❌ calixteman


Max Christian Pohle seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tmbrbr tmbrbr closed this pull request by merging all changes into SAP:main in 810ea9f Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Playwright v1.41