Fixing writing Taint flow information to file #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also address #246 once it is merged. |
|
We need to first merge #248 for the playwright merge action to succeed again. |
tmbrbr
commented
Jan 13, 2025
| // Enable this with ac_add_options --enable-taintspew | ||
| #if defined(JS_TAINTSPEW) | ||
| WriteTaintToFile(cx, str, retVal); | ||
| #endif | ||
| } |
There was a problem hiding this comment.
Need to add a call to MaybeSpewStringTaint here in the case that JitSpew is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few issues with writing tainting information to file, which are fixed with this PR.
Now the user has two options:
ac_add_options --enable-jitspewcompile flag plus theSPEW=TaintFlowSpewer,AtStartupenvironment variable at the start.ac_add_options --enable-taintspew. This option will output a single file per taint flow determined by theTAINT_FILEenvironment variable (ortaint_output) as the default.In both cases, information from the
__taintreportfunction such as URL and timestamp are now also included.