-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Github action to Test Browser Build #253
Conversation
Current iteration passes the build step, but packaging fails with:
|
Some disk usage statistics, before build (ie after the checkout):
|
Mozilla states around 30Gb is required for a build: https://firefox-source-docs.mozilla.org/setup/linux_build.html. |
The default GitHub runners have a lot of stuff installed to be able to build just about everything (Docker images, Android SDKs, Node.js, Java, ...). See for example this ticket: actions/runner-images#10386 There are Actions plugins available to free up space: https://github.com/marketplace/actions/free-disk-space-ubuntu |
All checks have passed! 🎉 |
At the moment there is an issue that bash cannot find msys2/MSYS2-packages#334 |
The underlying problem is that extracting mozilla build tools via 7z does not contain all the directories needed by the installer (including tmp). |
Now the build is starting but we are into the actual build errors! The good news is that it looks like a windows build is in principle possible via github actions! 🎉 The error message is:
The bootstrap installs Rust 1.84 by default, according to https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html we need Rust 1.77.2. We need to do something similar to the build script: https://github.com/sap/project-foxhound/blob/main/build.sh#L146 |
All checks have passed!! 🎉 |
I am impressed with how stable the GitHub runner builds are by now. I remember a few years ago we kept running into memory problems and the jobs kept getting killed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We had a Github action to build the full browser a while ago, but it was fairly flakey due to memory limitations.
Trying again to see if there is more stability now.
One advantage now is that there are also windows and mac runners, which could eventually lead to automated builds for those targets.
Successful build targets so far: