-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
5 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
// async function with await | ||
sap.ui.define([], async () => { | ||
return await sap.ui.require(["static/module1"], async () => {}); | ||
// await and sap.ui.require, makes so sense because it does NOT return a promise but it should still be analyzed | ||
}); | ||
// async function with await | ||
sap.ui.define([], async () => { | ||
return await sap.ui.require(["static/module1"], async () => {}); | ||
// await and sap.ui.require, makes so sense because it does NOT return a promise but it should still be analyzed | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,7 @@ | ||
sap.ui.define([ | ||
'static/module1' | ||
], () => { | ||
|
||
// spread expression | ||
const dynamicModules = ["not-detected/module1"]; // TODO: should this be supported? | ||
sap.ui.require(["static/module1", ...dynamicModules]); | ||
|
||
}); |