[INTERNAL] LocatorResourcePool: pass through constructor arguments #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignoreMissingModules parameter is passed along now when creating a new LocatorResourcePool
matz3
reviewed
Aug 28, 2020
| @@ -3,8 +3,8 @@ const LocatorResource = require("./LocatorResource"); | |||
|
|
|||
|
|
|||
| class LocatorResourcePool extends ResourcePool { | |||
| constructor() { | |||
| super(); | |||
| constructor(parameters) { | |||
There was a problem hiding this comment.
AFAIK you can also just completely remove the constructor.
There was a problem hiding this comment.
kk (y) that's even better, I give it a try e5f88ac
remove constructor because it does not do anything extra
matz3
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignoreMissingModulesparameter is passed along now when creatinga
new LocatorResourcePoolworks in combination with #479 and #481